Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Link to SDK Service Account #3565

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

"GameServer Pod Service Accounts" didn't provide a reference to what the SDK service account permissions should be - so this updates the docs to the point to the relevant Helm yaml file that is the reference for this, with an accompanying warning on what getting your RBAC permissions wrong can do.

Which issue(s) this PR fixes:

Closes #3564

Special notes for your reviewer:

"GameServer Pod Service Accounts" didn't provide a reference to what the
SDK service account permissions should be - so this updates the docs to
the point to the relevant Helm yaml file that is the reference for this,
with an accompanying warning on what getting your RBAC permissions
wrong can do.

Closes googleforgames#3564
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Jan 3, 2024
@markmandel markmandel requested review from zmerlynn and gongmax January 3, 2024 05:03
@github-actions github-actions bot added kind/documentation Documentation for Agones size/XS labels Jan 3, 2024
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 493c987d-ecb8-496b-9963-80516bca7891

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3565/head:pr_3565 && git checkout pr_3565
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.38.0-dev-3a1593c-amd64

@gongmax gongmax merged commit eac649c into googleforgames:main Jan 3, 2024
4 checks passed
@markmandel markmandel deleted the docs/service-acount branch January 4, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service account permissions for logging
3 participants