Adds Counters and Lists to CSharp SDK #3581

igooch · 2024-01-09T20:59:19Z

What type of PR is this?

/kind feature

What this PR does / Why we need it:

Adds the C# SDK for Counters and Lists as part of the CountsAndLists feature.

Methods Implemented are based on the Go SDK methods in https://github.com/googleforgames/agones/blob/main/sdks/go/alpha.go:

func (a *Alpha) GetCounterCount(key string) (int64, error) -> Task<long> GetCounterCountAsync(string key);
func (a *Alpha) IncrementCounter(key string, amount int64) (error) -> Task IncrementCounterAsync(string key, long amount);
func (a *Alpha) DecrementCounter(key string, amount int64) (error) -> Task DecrementCounterAsync(string key, long amount);
func (a *Alpha) SetCounterCount(key string, amount int64) (error) -> Task SetCounterCountAsync(string key, long amount);
func (a *Alpha) GetCounterCapacity(key string) (int64, error) -> Task<long> GetCounterCapacityAsync(string key);
func (a *Alpha) SetCounterCapacity(key string, amount int64) (error) -> Task SetCounterCapacityAsync(string key, long amount);
func (a *Alpha) GetListCapacity(key string) (int64, error) -> Task<long> GetListCapacityAsync(string key);
func (a *Alpha) SetListCapacity(key string, amount int64) (error) -> Task SetListCapacityAsync(string key, long amount);
func (a *Alpha) ListContains(key, value string) (bool, error) -> Task<bool> ListContainsAsync(string key, string value);
func (a *Alpha) GetListLength(key string) (int, error) -> Task<int> GetListLengthAsync(string key);
func (a *Alpha) GetListValues(key string) ([]string, error) -> Task<IList<string>> GetListValuesAsync(string key);
func (a *Alpha) AppendListValue(key, value string) (error) -> Task AppendListValueAsync(string key, string value);
func (a *Alpha) DeleteListValue(key, value string) (error) -> Task DeleteListValueAsync(string key, string value);

Adds C# unit tests for the new methods. C# units tests can be run by navigating to agones/build and running make sdk-shell-csharp. Once in the C# shell navigate to the test folder /go/src/agones.dev/agones/sdks/csharp/test. From there use standard dotnet commands such as dotnet test --filter Counter to run the unit tests.

Adds C# conformance tests for the new methods. C# conformance tests can be run by navigating to agones/build and running make run-sdk-conformance-test-csharp.

Which issue(s) this PR fixes:

Working on #2716

Special notes for your reviewer:

agones-bot · 2024-01-09T21:13:28Z

Build Failed 😱

Build Id: 13535a09-4f14-4ab2-a4bc-35c8f69d4f0b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-01-10T00:40:50Z

Build Failed 😱

Build Id: c232f224-6be3-4e5c-962c-0204879b503a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-01-10T19:11:46Z

Build Failed 😱

Build Id: 98887958-1ee3-4108-ad2e-e9db4e7f777b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-01-10T19:50:00Z

Build Failed 😱

Build Id: f82ba555-097b-4282-9a56-5fa374b7af25

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-01-11T04:15:31Z

Build Succeeded 👏

Build Id: 6b8d1859-a3b7-49f3-b9a0-f9ede7175f3c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://8ec5a51-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3581/head:pr_3581 && git checkout pr_3581
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.38.0-dev-8ec5a51-amd64

agones-bot · 2024-01-12T01:21:38Z

Build Succeeded 👏

Build Id: ab391311-9c52-42b9-8ebe-dbf031d484fe

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://5117703-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3581/head:pr_3581 && git checkout pr_3581
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.38.0-dev-5117703-amd64

agones-bot · 2024-01-12T04:29:25Z

Build Succeeded 👏

Build Id: 86e9f86b-65c6-4530-845a-5454829682c4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://e132cb5-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3581/head:pr_3581 && git checkout pr_3581
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.38.0-dev-e132cb5-amd64

agones-bot · 2024-01-22T23:48:36Z

Build Failed 😱

Build Id: 0a1af7a6-636c-469b-bbee-3f266349ce78

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-01-23T03:35:57Z

Build Succeeded 👏

Build Id: 79a22e86-25e5-4408-b938-ba541e1db0b0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://6fe950d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3581/head:pr_3581 && git checkout pr_3581
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.38.0-dev-6fe950d-amd64

agones-bot · 2024-01-23T20:54:18Z

Build Succeeded 👏

Build Id: cc02755a-7f15-426d-8815-da2eac3e11ba

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://bb383cf-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3581/head:pr_3581 && git checkout pr_3581
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.38.0-dev-bb383cf-amd64

github-actions · 2024-03-30T00:45:55Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-03-30T01:56:18Z

Build Succeeded 👏

Build Id: 0229cd4d-6001-4be5-8f57-64cba555a437

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://80d474b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3581/head:pr_3581 && git checkout pr_3581
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-80d474b-amd64

github-actions · 2024-04-01T21:15:15Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-04-01T22:20:37Z

Build Succeeded 👏

Build Id: 0d1438df-ce86-40e7-96db-f084d47e3fd5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://e70f45d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3581/head:pr_3581 && git checkout pr_3581
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-e70f45d-amd64

markmandel

Just need feature shortcodes in the docs, then I think this is good to merge.

site/content/en/docs/Guides/Client SDKs/csharp.md

github-actions · 2024-04-01T23:30:40Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-04-02T00:49:22Z

Build Failed 😱

Build Id: 4a420991-2a14-48d4-bd1d-d134e8e37939

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2024-04-02T00:54:32Z

Really need to fix this flake:

E: time="2024-04-02 00:48:53.552" level=info msg="Finished Allocation."
VERBOSE:     gameserverallocation_test.go:1442: 
VERBOSE:         	Error Trace:	/go/src/agones.dev/agones/test/e2e/gameserverallocation_test.go:1442
VERBOSE:         	Error:      	Not equal: 
VERBOSE:         	            	expected: 100
VERBOSE:         	            	actual  : 99
VERBOSE:         	Test:       	TestGameServerAllocationDuringMultipleAllocationClients
VERBOSE: --- FAIL: TestGameServerAllocationDuringMultipleAllocationClients (60.57s)

github-actions · 2024-04-02T01:04:54Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-04-02T02:03:36Z

Build Succeeded 👏

Build Id: d16af8ea-6837-4dec-a3e8-0e84b184907e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://d97b23f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3581/head:pr_3581 && git checkout pr_3581
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-d97b23f-amd64

to instead return Task<void>.

This also includes some fixes for PlayerTracking, so it's all formatted consistently.

github-actions · 2024-04-02T23:36:00Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

markmandel · 2024-04-02T23:36:49Z

@zmerlynn can you do a final approval on this? I just pushed up some formatting changes to the documentation to Ivy's branch and felt weird approving my own changes 😄

zmerlynn

I approve your last commit. :)

agones-bot · 2024-04-03T00:42:20Z

Build Succeeded 👏

Build Id: 25f0a1fa-a3c6-4d29-85c0-ae9aa210fafe

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://91ec59d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3581/head:pr_3581 && git checkout pr_3581
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-91ec59d-amd64

github-actions bot added kind/hotfix Hotfixes for issues against release size/S labels Jan 9, 2024

igooch force-pushed the csharpsdk branch from 44febd1 to 8c16483 Compare January 9, 2024 21:03

igooch force-pushed the csharpsdk branch from 8c16483 to 4b47456 Compare January 10, 2024 00:31

igooch force-pushed the csharpsdk branch from 4b47456 to 422e5ee Compare January 10, 2024 18:58

igooch force-pushed the csharpsdk branch from 422e5ee to a878647 Compare January 10, 2024 19:35

igooch force-pushed the csharpsdk branch 2 times, most recently from 30cb412 to 8ec5a51 Compare January 11, 2024 02:32

igooch force-pushed the csharpsdk branch from 8ec5a51 to 5117703 Compare January 12, 2024 00:19

github-actions bot added the kind/feature New features for Agones label Jan 12, 2024

github-actions bot added the size/M label Jan 12, 2024

igooch force-pushed the csharpsdk branch from c8e729f to e132cb5 Compare January 12, 2024 03:02

igooch removed the kind/hotfix Hotfixes for issues against release label Jan 22, 2024

igooch force-pushed the csharpsdk branch from e132cb5 to 7886363 Compare January 22, 2024 23:30

igooch force-pushed the csharpsdk branch from 7886363 to 6fe950d Compare January 23, 2024 02:33

igooch force-pushed the csharpsdk branch from 6fe950d to bb383cf Compare January 23, 2024 19:56

igooch force-pushed the csharpsdk branch 4 times, most recently from f089669 to 5c6b7fa Compare February 5, 2024 17:08

igooch force-pushed the csharpsdk branch from 80d474b to e70f45d Compare April 1, 2024 21:14

markmandel reviewed Apr 1, 2024

View reviewed changes

site/content/en/docs/Guides/Client SDKs/csharp.md Outdated Show resolved Hide resolved

site/content/en/docs/Guides/Client SDKs/csharp.md Outdated Show resolved Hide resolved

site/content/en/docs/Guides/Client SDKs/csharp.md Show resolved Hide resolved

igooch mentioned this pull request Apr 1, 2024

Nodejs counters and lists #3726

Merged

igooch and others added 8 commits April 2, 2024 16:35

Adds Counter methods to CSharp SDK

6f88029

Adds Lists to Csharp SDK

0f5c039

Minor change to more succinctly convert a collection to a list

ed761f5

Minor formatting update

6fdfbb0

Updates Task<bool> methods that have no meaningful return value

065ea65

to instead return Task<void>.

Adds csharp client SDK documentation for counts and lists

d76b272

Adds feature publication gate for the csharp SDK to the Agones docs

2aae68f

Formatting fixes for the C# SDK documentation.

91ec59d

This also includes some fixes for PlayerTracking, so it's all formatted consistently.

markmandel force-pushed the csharpsdk branch from d97b23f to 91ec59d Compare April 2, 2024 23:35

markmandel requested a review from zmerlynn April 2, 2024 23:36

zmerlynn approved these changes Apr 3, 2024

View reviewed changes

zmerlynn enabled auto-merge (squash) April 3, 2024 00:04

zmerlynn merged commit f4403e8 into googleforgames:main Apr 3, 2024
4 checks passed

igooch deleted the csharpsdk branch July 16, 2024 19:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds Counters and Lists to CSharp SDK #3581

Adds Counters and Lists to CSharp SDK #3581

igooch commented Jan 9, 2024 •

edited

Loading

agones-bot commented Jan 9, 2024

agones-bot commented Jan 10, 2024

agones-bot commented Jan 10, 2024

agones-bot commented Jan 10, 2024

agones-bot commented Jan 11, 2024

agones-bot commented Jan 12, 2024

agones-bot commented Jan 12, 2024

agones-bot commented Jan 22, 2024

agones-bot commented Jan 23, 2024

agones-bot commented Jan 23, 2024

github-actions bot commented Mar 30, 2024

agones-bot commented Mar 30, 2024

github-actions bot commented Apr 1, 2024

agones-bot commented Apr 1, 2024

markmandel left a comment

github-actions bot commented Apr 1, 2024

agones-bot commented Apr 2, 2024

markmandel commented Apr 2, 2024

github-actions bot commented Apr 2, 2024

agones-bot commented Apr 2, 2024

github-actions bot commented Apr 2, 2024

markmandel commented Apr 2, 2024 •

edited

Loading

zmerlynn left a comment

agones-bot commented Apr 3, 2024

Adds Counters and Lists to CSharp SDK #3581

Adds Counters and Lists to CSharp SDK #3581

Conversation

igooch commented Jan 9, 2024 • edited Loading

agones-bot commented Jan 9, 2024

agones-bot commented Jan 10, 2024

agones-bot commented Jan 10, 2024

agones-bot commented Jan 10, 2024

agones-bot commented Jan 11, 2024

agones-bot commented Jan 12, 2024

agones-bot commented Jan 12, 2024

agones-bot commented Jan 22, 2024

agones-bot commented Jan 23, 2024

agones-bot commented Jan 23, 2024

github-actions bot commented Mar 30, 2024

agones-bot commented Mar 30, 2024

github-actions bot commented Apr 1, 2024

agones-bot commented Apr 1, 2024

markmandel left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 1, 2024

agones-bot commented Apr 2, 2024

markmandel commented Apr 2, 2024

github-actions bot commented Apr 2, 2024

agones-bot commented Apr 2, 2024

github-actions bot commented Apr 2, 2024

markmandel commented Apr 2, 2024 • edited Loading

zmerlynn left a comment

Choose a reason for hiding this comment

agones-bot commented Apr 3, 2024

igooch commented Jan 9, 2024 •

edited

Loading

markmandel commented Apr 2, 2024 •

edited

Loading