Counters: Update Default Capacity

[Kalaiselvi84]

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #3579

Special notes for your reviewer:

[agones-bot]

Build Failed 😱

Build Id: 1672ec84-b184-498d-ac94-fd4f38d9f773

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Failed 😱

Build Id: e0f268de-d427-435c-864b-97fe61afb59c

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[igooch]

Try running make gen-install from within the agones/build directory.

[Kalaiselvi84]

shall I revert the change in install/yaml/install.yaml and try make gen-install?

[agones-bot]

Build Succeeded 👏

Build Id: 90168406-8321-4437-bb58-206c3dfaa297

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.38.0-dev-eab2df1-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.38.0-dev-eab2df1-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.38.0-dev-eab2df1-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.38.0-dev-eab2df1-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.38.0-dev-eab2df1-amd64
• Linux C++ SDK (build): agonessdk-1.38.0-dev-eab2df1-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.38.0-dev-eab2df1-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://eab2df1-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3594/head:pr_3594 && git checkout pr_3594
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.38.0-dev-eab2df1-amd64

[Kalaiselvi84]

I have tested with Counters default capacity with 9223372036854775807 and 0.

Is 0 correct for the Counters default capacity?

The Counters info are missing in the status with 9223372036854775807

Counters are present with 0

[igooch]

The TL;DR is currently our max capacity per game server = max(int64) / replicas.

The fleet aggregates the count and capacity of all the game servers counters in the fleet. So if game server counter capacity = max(int64) and there are 3 replicas in the fleet, then the fleet aggregate counter capacity = 3 * max(int64) which errors. When I put in max(int64) / 3 as the max capacity for a game server, then the fleet and game servers started up just fine.

We'll need to change the code, and documentation, so that if the aggregate capacity or count for the fleet goes above max(int64), then the aggregate would be max(int64), so that we don't get an error on aggregation. We should probably do this as a separate PR before updating the defaults.

[igooch]

Opened #3604 to address the aggregating past int64 issue.

[markmandel]

Just holding off on this one until we decide if we should make count capacity nullable and the Go model *capacity to indicate essentially unlimited capacity.

@igooch @zmerlynn WDYT? (from chat discussion)

[Kalaiselvi84]

This link shows the example using big.NewInt to handle the larger number.

[Kalaiselvi84]

@markmandel, @zmerlynn, and @igooch, have we decided on updating the default capacity for the Counters or keeping it as is?

[markmandel]

Just checking - but @igooch @zmerlynn we can merge this as is now?

If I really want the max capacity to be represented by nil once I've looked at the developer experience, I'll roll up my sleeves and make the chage.

Sound good?

[igooch]

We can't have this default to max(int64) because of the issue with jsonpatch being lossy. So we'll need some other arbitrary value for default.

[Kalaiselvi84]

Closing this PR and focusing on the documentation updates in PR #3637