-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Golang Version to 1.21.6 #3602
Conversation
The Please confirm if this looks good to you to push these new images to production. I will commit the remaining file updates in this PR after the push. |
Build Succeeded 👏 Build Id: 84d3ec9f-3e36-464b-98f2-15ad3facefff The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
LGTM! @igooch you got anything? |
We should update the mod files as well for the main repo and the examples |
Good call 👍🏻 |
Installed the Go v1.21.6. and updated the mod files using |
We should update for the go.mod files in the examples/ directories as well. |
I used the same commands but mod files haven't modified. Am I missing anything? ~/Desktop/agones/examples$ go mod edit -go=1.21 |
Build Succeeded 👏 Build Id: 2ba7dc08-07ff-489a-bb33-ccac205f4e44 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Following commands help to update the subdirectories of mod and sum files: agones/examples$ find . -name 'go.mod' -execdir go mod edit -go=1.21 ; |
Build Failed 😱 Build Id: 5a70d1aa-46b2-42e0-8fad-040d9e655693 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Test failure will likely be fixed with #3603. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. @igooch anything else on your end?
Build Succeeded 👏 Build Id: 0206cbc8-41bf-4cd5-9315-162aa9fe885a The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: f9750657-b6a6-4e69-a586-dd6573605f92 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Which issue(s) this PR fixes:
Closes #3601
Special notes for your reviewer: