-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to https://github.com/gomodules/jsonpatch #3639
Conversation
It's better we're on the same project that controller-runtime uses so we can take advantage of any upstream security and bugfixes that may occur - or have occurred already! Work on googleforgames#3636 - since if that issue gets fixed, it will get fixed here. Also, it ws a fun little fix to work on 😃
Build Succeeded 👏 Build Id: d2cfa4d6-3552-4679-b0e9-bb898c90af68 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Failed 😱 Build Id: 5ecedd06-b7f8-48ba-be37-653614989673 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
That's a new one! Happened during "submit-e2e-test-cloud-build". Weird! |
Build Succeeded 👏 Build Id: 996d86d9-ce22-4dbe-a69c-be7c34fe065c The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
It's better we're on the same project that controller-runtime uses so we can take advantage of any upstream security and bugfixes that may occur - or have occurred already!
Which issue(s) this PR fixes:
Work on #3636 - since if that issue gets fixed, it will get fixed here.
Special notes for your reviewer:
Also, it was a fun little fix to work on 😃