Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to https://github.com/gomodules/jsonpatch #3639

Merged
merged 2 commits into from
Feb 10, 2024

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

It's better we're on the same project that controller-runtime uses so we can take advantage of any upstream security and bugfixes that may occur - or have occurred already!

Which issue(s) this PR fixes:

Work on #3636 - since if that issue gets fixed, it will get fixed here.
Special notes for your reviewer:

Also, it was a fun little fix to work on 😃

It's better we're on the same project that controller-runtime uses so we
can take advantage of any upstream security and bugfixes that may occur
- or have occurred already!

Work on googleforgames#3636 - since if that issue gets fixed, it will get fixed here.

Also, it ws a fun little fix to work on 😃
@github-actions github-actions bot added kind/cleanup Refactoring code, fixing up documentation, etc size/L labels Feb 9, 2024
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d2cfa4d6-3552-4679-b0e9-bb898c90af68

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3639/head:pr_3639 && git checkout pr_3639
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.39.0-dev-9bf03e0-amd64

@zmerlynn zmerlynn enabled auto-merge (squash) February 9, 2024 16:39
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 5ecedd06-b7f8-48ba-be37-653614989673

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

Already have image (with digest): gcr.io/cloud-builders/gcloud
generic-1.28: ERROR: gcloud crashed (FileNotFoundError): [Errno 2] No such file or directory: 'site/public/images'
generic-1.28: 
generic-1.28: If you would like to report this issue, please run the following command:
generic-1.28:   gcloud feedback
generic-1.28: 
generic-1.28: To check gcloud for common problems, please run the following command:
generic-1.28:   gcloud info --run-diagnostics
generic-1.27: ERROR: gcloud crashed (FileNotFoundError): [Errno 2] No such file or directory: 'site/public/images'
generic-1.27: 
generic-1.27: If you would like to report this issue, please run the following command:
generic-1.27:   gcloud feedback
generic-1.27: 
generic-1.27: To check gcloud for common problems, please run the following command:
generic-1.27:   gcloud info --run-diagnostics

That's a new one! Happened during "submit-e2e-test-cloud-build". Weird!

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 996d86d9-ce22-4dbe-a69c-be7c34fe065c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3639/head:pr_3639 && git checkout pr_3639
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.39.0-dev-2bd47c9-amd64

@zmerlynn zmerlynn merged commit 8b2c442 into googleforgames:main Feb 10, 2024
4 checks passed
@markmandel markmandel deleted the cleanup/jsonpatch branch February 12, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants