Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky: TestGameServerCreationAfterDeletingOneExtensionsPod #3699

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Flaky: TestGameServerCreationAfterDeletingOneExtensionsPod #3699

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0be9fb
Flaky: TestGameServerCreationAfterDeletingOneExtensionsPod
markmandel Mar 12, 2024
1d5d3da
Merge branch 'main' into flaky/TestGameServerCreationAfterDeletingOne…
zmerlynn Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 12 additions & 16 deletions test/e2e/extensions/high_availability_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ func TestGameServerCreationAfterDeletingOneExtensionsPod(t *testing.T) {

assert.NoError(t, waitForAgonesExtensionsRunning(ctx))

list, err := getAgoneseExtensionsPods(ctx)
list, err := getAgonesExtensionsPods(ctx)
logger.Infof("Length of pod list is %v", len(list.Items))
if len(list.Items) > 2 {
logger.WithField("podCount", len(list.Items)).Info("Logging events for the Deployment due to pod count > 2 before deleting extensions pod")
Expand All @@ -52,7 +52,7 @@ func TestGameServerCreationAfterDeletingOneExtensionsPod(t *testing.T) {
}
}
require.NoError(t, err, "Could not get list of Extension pods")
assert.Greater(t, len(list.Items), 1, "Cluster has no Extensions pod or has only 1 extensions pod")
require.Greater(t, len(list.Items), 1, "Cluster has no Extensions pod or has only 1 extensions pod")

logger.Infof("Removing one of the Extensions Pods: %v", list.Items[1].ObjectMeta.Name)
deleteAgonesExtensionsPod(ctx, t, true)
Expand All @@ -65,7 +65,7 @@ func TestGameServerCreationAfterDeletingOneExtensionsPod(t *testing.T) {
require.NoError(t, err, "Could not get a GameServer ready")
logger.WithField("gsKey", readyGs.ObjectMeta.Name).Info("GameServer Ready")

assert.NoError(t, framework.AgonesClient.AgonesV1().GameServers(defaultNs).Delete(ctx, readyGs.ObjectMeta.Name, metav1.DeleteOptions{})) // nolint: errcheck
require.NoError(t, framework.AgonesClient.AgonesV1().GameServers(defaultNs).Delete(ctx, readyGs.ObjectMeta.Name, metav1.DeleteOptions{}))
}

func TestGameServerCreationRightAfterDeletingOneExtensionsPod(t *testing.T) {
Expand All @@ -74,7 +74,7 @@ func TestGameServerCreationRightAfterDeletingOneExtensionsPod(t *testing.T) {

assert.NoError(t, waitForAgonesExtensionsRunning(ctx))

list, err := getAgoneseExtensionsPods(ctx)
list, err := getAgonesExtensionsPods(ctx)
logger.Infof("Length of pod list is %v", len(list.Items))
for i := range list.Items {
logger.Infof("Name of extensions pod %v: %v", i, list.Items[i].ObjectMeta.Name)
Expand All @@ -97,7 +97,7 @@ func TestGameServerCreationRightAfterDeletingOneExtensionsPod(t *testing.T) {
// deleteAgonesExtensionsPod deletes one of the extensions pod for the Agones extensions,
// faking a extensions pod crash.
func deleteAgonesExtensionsPod(ctx context.Context, t *testing.T, waitForExtensions bool) {
list, err := getAgoneseExtensionsPods(ctx)
list, err := getAgonesExtensionsPods(ctx)
require.NoError(t, err, "Could not get list of Extension pods")

policy := metav1.DeletePropagationBackground
Expand All @@ -115,29 +115,25 @@ func deleteAgonesExtensionsPod(ctx context.Context, t *testing.T, waitForExtensi

func waitForAgonesExtensionsRunning(ctx context.Context) error {
return wait.PollUntilContextTimeout(ctx, time.Second, 5*time.Minute, true, func(ctx context.Context) (bool, error) {
list, err := getAgoneseExtensionsPods(ctx)
list, err := getAgonesExtensionsPods(ctx)
if err != nil {
return true, err
}

if len(list.Items) != 2 {
return false, nil
}

// count the number of Running instances
count := 0
for i := range list.Items {
for _, c := range list.Items[i].Status.ContainerStatuses {
if c.State.Running == nil {
return false, nil
}
if list.Items[i].Status.Phase == corev1.PodRunning {
count++
}
}

return true, nil
return count == 2, nil
})
}

// getAgonesExtensionsPods returns all the Agones extensions pods
func getAgoneseExtensionsPods(ctx context.Context) (*corev1.PodList, error) {
func getAgonesExtensionsPods(ctx context.Context) (*corev1.PodList, error) {
opts := metav1.ListOptions{LabelSelector: labels.Set{"agones.dev/role": "extensions"}.String()}
pods, err := framework.KubeClient.CoreV1().Pods("agones-system").List(ctx, opts)
if err != nil {
Expand Down
Loading