-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Canary Testing Documentation #3760
Conversation
Build Succeeded 👏 Build Id: 6bd95df8-e6cb-4cdc-a256-8e5aebd354ff The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing the "selectors" field, and we should remove the players selector. Also included a quick question for Mark on how he wants the labels to look.
canary: "true" | ||
required: | ||
matchLabels: | ||
- matchLabels: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markmandel do you have any preference on if this examples uses the labels canary: "true"
canary: "false"
or agones.dev/fleet: green-fleet
agones.dev/fleet: blue-fleet
?
selectors:
- matchLabels:
canary: "true"
agones.dev/fleet: green-fleet
Build Failed 😱 Build Id: 7fc24c8e-029b-46bc-9bab-04654c29fdf6 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
selectors: | ||
- matchLabels: | ||
canary: "true" | ||
required: | ||
matchLabels: | ||
agones.dev/fleet: stable | ||
agones.dev/fleet: stable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So right now this is a "canary and fleet is 'stable'" - what we actually want is "check the canary label'ed GameServers, and if there are none left, then go to the 'stable' fleet.
So we want this instead:
apiVersion: allocation.agones.dev/v1
kind: GameServerAllocation
spec:
selectors:
- matchLabels:
canary: "true"
- matchLabels:
agones.dev/fleet: stable
Which will first look for the first selector, and if it fails go to the second.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made the changes you recommended.
Build Succeeded 👏 Build Id: 82ac2828-688f-46eb-8d3b-29ba35879f1b The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Build Succeeded 👏 Build Id: fef90ca8-0886-41a8-a3a5-a40b7ac57016 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [agones](https://agones.dev) ([source](https://togithub.com/googleforgames/agones)) | minor | `1.39.0` -> `1.40.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>googleforgames/agones (agones)</summary> ### [`v1.40.0`](https://togithub.com/googleforgames/agones/blob/HEAD/CHANGELOG.md#v1400-2024-04-23) [Compare Source](https://togithub.com/googleforgames/agones/compare/v1.39.0...v1.40.0) [Full Changelog](https://togithub.com/googleforgames/agones/compare/v1.39.0...v1.40.0) **Breaking changes:** - Counters and Lists: Remove Bool Returns by [@​Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3738](https://togithub.com/googleforgames/agones/pull/3738) **Implemented enhancements:** - Leader Election in Custom Controller by [@​Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3696](https://togithub.com/googleforgames/agones/pull/3696) - Migrating from generate-groups.sh to kube_codegen.sh by [@​Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3722](https://togithub.com/googleforgames/agones/pull/3722) - Move GKEAutopilotExtendedDurationPods to Alpha in 1.28+ by [@​zmerlynn](https://togithub.com/zmerlynn) in [https://github.com/googleforgames/agones/pull/3729](https://togithub.com/googleforgames/agones/pull/3729) - Move DisableResyncOnSDKServer to Beta by [@​Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3732](https://togithub.com/googleforgames/agones/pull/3732) - Counters & Lists landing page and doc improvements by [@​markmandel](https://togithub.com/markmandel) in [https://github.com/googleforgames/agones/pull/3649](https://togithub.com/googleforgames/agones/pull/3649) - Graduate FleetAllocationOverflow to Stable by [@​Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3733](https://togithub.com/googleforgames/agones/pull/3733) - Adds Counters and Lists to CSharp SDK by [@​igooch](https://togithub.com/igooch) in [https://github.com/googleforgames/agones/pull/3581](https://togithub.com/googleforgames/agones/pull/3581) - Feat/counter and list defaulting order to ascending by [@​lacroixthomas](https://togithub.com/lacroixthomas) in [https://github.com/googleforgames/agones/pull/3734](https://togithub.com/googleforgames/agones/pull/3734) - Add handling for StatusAddresses in GameServerStatus for the Unity SDK by [@​charlesvien](https://togithub.com/charlesvien) in [https://github.com/googleforgames/agones/pull/3739](https://togithub.com/googleforgames/agones/pull/3739) - Feat(gameservers): Shared pod IPs with GameServer Addresses by [@​lacroixthomas](https://togithub.com/lacroixthomas) in [https://github.com/googleforgames/agones/pull/3764](https://togithub.com/googleforgames/agones/pull/3764) - Be prescriptive about rotating regions when updating Kubernetes versions by [@​zmerlynn](https://togithub.com/zmerlynn) in [https://github.com/googleforgames/agones/pull/3716](https://togithub.com/googleforgames/agones/pull/3716) - Fix ensure-e2e-infra-state-bucket by [@​zmerlynn](https://togithub.com/zmerlynn) in [https://github.com/googleforgames/agones/pull/3719](https://togithub.com/googleforgames/agones/pull/3719) - Create Performance Cluster 1.28 by [@​Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3720](https://togithub.com/googleforgames/agones/pull/3720) - Optimise GameServer Sub-Controller Queues by [@​markmandel](https://togithub.com/markmandel) in [https://github.com/googleforgames/agones/pull/3781](https://togithub.com/googleforgames/agones/pull/3781) **Fixed bugs:** - Counters & Lists: Consolidate `priorities` sorting by [@​markmandel](https://togithub.com/markmandel) in [https://github.com/googleforgames/agones/pull/3690](https://togithub.com/googleforgames/agones/pull/3690) - Fix(Counter & Lists): Add validation for `priorities` by [@​lacroixthomas](https://togithub.com/lacroixthomas) in [https://github.com/googleforgames/agones/pull/3714](https://togithub.com/googleforgames/agones/pull/3714) - fix: [#​3607](https://togithub.com/googleforgames/agones/issues/3607) Metrics data loss in K8S controller by [@​alvin-7](https://togithub.com/alvin-7) in [https://github.com/googleforgames/agones/pull/3692](https://togithub.com/googleforgames/agones/pull/3692) - Deflake GameServerAllocationDuringMultipleAllocationClients by allowing errors by [@​Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3750](https://togithub.com/googleforgames/agones/pull/3750) **Security fixes:** - Bump protobufjs from 7.2.4 to 7.2.6 in /sdks/nodejs by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/googleforgames/agones/pull/3755](https://togithub.com/googleforgames/agones/pull/3755) - Bump golang.org/x/net from 0.19.0 to 0.23.0 by [@​zmerlynn](https://togithub.com/zmerlynn) in [https://github.com/googleforgames/agones/pull/3793](https://togithub.com/googleforgames/agones/pull/3793) **Other:** - Flaky: TestGameServerCreationAfterDeletingOneExtensionsPod by [@​markmandel](https://togithub.com/markmandel) in [https://github.com/googleforgames/agones/pull/3699](https://togithub.com/googleforgames/agones/pull/3699) - Prep for release v1.40.0 by [@​Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3700](https://togithub.com/googleforgames/agones/pull/3700) - Bumps cpp-simple Image and Refactoring Example Makefiles by [@​Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3695](https://togithub.com/googleforgames/agones/pull/3695) - Upgrade Protobuf to 1.33.0 by [@​Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3711](https://togithub.com/googleforgames/agones/pull/3711) - Modify Script for Makefile Version Updates in Examples Directory by [@​Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3712](https://togithub.com/googleforgames/agones/pull/3712) - Adds simple genai server example documentation to the Agones site by [@​igooch](https://togithub.com/igooch) in [https://github.com/googleforgames/agones/pull/3713](https://togithub.com/googleforgames/agones/pull/3713) - Update Supported Kubernetes to 1.27, 1.28, 1.29 by [@​Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3654](https://togithub.com/googleforgames/agones/pull/3654) - fix: typo in docs by [@​qhyun2](https://togithub.com/qhyun2) in [https://github.com/googleforgames/agones/pull/3723](https://togithub.com/googleforgames/agones/pull/3723) - Tweak: Setting up the Game Server by [@​Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3717](https://togithub.com/googleforgames/agones/pull/3717) - Docs: gke.md - spelling by [@​daniellee](https://togithub.com/daniellee) in [https://github.com/googleforgames/agones/pull/3740](https://togithub.com/googleforgames/agones/pull/3740) - Aesthetic rearrangement of cloudbuild.yaml by [@​zmerlynn](https://togithub.com/zmerlynn) in [https://github.com/googleforgames/agones/pull/3741](https://togithub.com/googleforgames/agones/pull/3741) - Docs: Make hitting <enter> on connection explicit by [@​markmandel](https://togithub.com/markmandel) in [https://github.com/googleforgames/agones/pull/3743](https://togithub.com/googleforgames/agones/pull/3743) - CI: Don't check Unreal Link by [@​markmandel](https://togithub.com/markmandel) in [https://github.com/googleforgames/agones/pull/3745](https://togithub.com/googleforgames/agones/pull/3745) - New recommendation for multi-cluster allocation by [@​markmandel](https://togithub.com/markmandel) in [https://github.com/googleforgames/agones/pull/3744](https://togithub.com/googleforgames/agones/pull/3744) - Custom Controller Example Page on Agones Website by [@​Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3725](https://togithub.com/googleforgames/agones/pull/3725) - Add Nitrado logo by [@​towolf](https://togithub.com/towolf) in [https://github.com/googleforgames/agones/pull/3753](https://togithub.com/googleforgames/agones/pull/3753) - Remove unnecessary args from e2e-test-cloudbuild by [@​zmerlynn](https://togithub.com/zmerlynn) in [https://github.com/googleforgames/agones/pull/3754](https://togithub.com/googleforgames/agones/pull/3754) - Update Allocation from Fleet Documentation by [@​Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3761](https://togithub.com/googleforgames/agones/pull/3761) - Transform Lint Warnings into Errors by [@​Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3756](https://togithub.com/googleforgames/agones/pull/3756) - Update Canary Testing Documentation by [@​Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3760](https://togithub.com/googleforgames/agones/pull/3760) - Supertuxkart Example on Agones Site by [@​Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3728](https://togithub.com/googleforgames/agones/pull/3728) - Xonotic Example on Agones Site by [@​Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3742](https://togithub.com/googleforgames/agones/pull/3742) - nit documentation fix in kind cluster section when building Agones by [@​vicentefb](https://togithub.com/vicentefb) in [https://github.com/googleforgames/agones/pull/3770](https://togithub.com/googleforgames/agones/pull/3770) - Merged steps inside documentation about webhook certificate creation by [@​vicentefb](https://togithub.com/vicentefb) in [https://github.com/googleforgames/agones/pull/3768](https://togithub.com/googleforgames/agones/pull/3768) - Example Images: Increment Tags by [@​Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [https://github.com/googleforgames/agones/pull/3796](https://togithub.com/googleforgames/agones/pull/3796) - Update simple game server example documentation by [@​vicentefb](https://togithub.com/vicentefb) in [https://github.com/googleforgames/agones/pull/3776](https://togithub.com/googleforgames/agones/pull/3776) **New Contributors:** - [@​lacroixthomas](https://togithub.com/lacroixthomas) made their first contribution in [https://github.com/googleforgames/agones/pull/3714](https://togithub.com/googleforgames/agones/pull/3714) - [@​daniellee](https://togithub.com/daniellee) made their first contribution in [https://github.com/googleforgames/agones/pull/3740](https://togithub.com/googleforgames/agones/pull/3740) - [@​charlesvien](https://togithub.com/charlesvien) made their first contribution in [https://github.com/googleforgames/agones/pull/3739](https://togithub.com/googleforgames/agones/pull/3739) - [@​vicentefb](https://togithub.com/vicentefb) made their first contribution in [https://github.com/googleforgames/agones/pull/3770](https://togithub.com/googleforgames/agones/pull/3770) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTYuMSIsInVwZGF0ZWRJblZlciI6IjM3LjM1Ni4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9taW5vciJdfQ==-->
What type of PR is this?
What this PR does / Why we need it:
Which issue(s) this PR fixes:
Closes #3758
Special notes for your reviewer: