Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update site documentation to reflect firewall prefix and default to Autopilot cluster creation for Agones #3769
Update site documentation to reflect firewall prefix and default to Autopilot cluster creation for Agones #3769
Changes from 2 commits
6b24311
d51c107
a0a6606
f437027
3be0171
9412981
cbf0d3d
60c1b17
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should resolve to either the local or which snapshot version you are seeing - so it can't point at the domain directly.
You can use:
agones/site/config.toml
Line 15 in 772fffb
As the root of the link, via:
https://gohugo.io/templates/shortcode-templates/#:~:text=Params.shortcode_color).-,%24.Page.Site.Params,-refers%20to%20parameters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okok sg, i used /site/ now inside the href
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what @markmandel is saying is that even
baseURL
could be variable, so you need to use a function here to grab the config.@markmandel any reason we can't use https://gohugo.io/methods/site/baseurl/ here? I think this just becomes
{{ .Site.BaseURL }}docs/installation/creating-cluster/gke/#creating-the-firewall
.