Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes sdk-server to Patch instead of Update #3803

Merged
merged 15 commits into from
May 8, 2024
Merged

Changes sdk-server to Patch instead of Update #3803

merged 15 commits into from
May 8, 2024

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Apr 24, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / Why we need it:

See #3767#update-vs-patch

Which issue(s) this PR fixes:

Completes part II of #3767

Special notes for your reviewer:

I did not change PlayerTracking as the feature will be deprecated.

@github-actions github-actions bot added kind/feature New features for Agones size/M labels Apr 24, 2024
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 86bfdc40-16f8-4b7c-9f66-cf7812f23e98

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: b33662d3-a2bc-44ba-85ed-b7c3bd96199e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 0bbdb825-9db9-4c47-8deb-dfbc6a540804

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 6815d91e-df07-468a-922f-42c5d57d534e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: ffad0a56-986c-48b8-926c-e33bbe3b302a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the inPlaceUpgrades branch 2 times, most recently from 527291f to 70720cb Compare April 29, 2024 20:18
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 0874d154-d557-4d95-8758-960a7224cf59

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 9082097e-571a-4d84-bb83-1aa9f2e8cf1e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: b2d07549-18e8-46a9-a787-2428b249bbae

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: ef3b3b58-9825-4533-aeb9-18c573b9a9de

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch marked this pull request as ready for review April 30, 2024 18:52
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 13a4d9ab-7c88-4197-aeee-b32788db2b1b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3803/head:pr_3803 && git checkout pr_3803
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.41.0-dev-609791e-amd64

@igooch igooch requested a review from zmerlynn April 30, 2024 20:28
@zmerlynn zmerlynn changed the title Changes UpdateLabels to Patch instead of Update Changes sdk-server to Patch instead of Update Apr 30, 2024
zmerlynn
zmerlynn approved these changes Apr 30, 2024
View reviewed changes
pkg/sdkserver/sdkserver_test.go Outdated Show resolved Hide resolved
@zmerlynn
Copy link
Collaborator

cc @markmandel (but I'm happy to proceed with this, we have plenty of time to CI)

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 90eaea65-b207-494b-a0b5-51b9b1f16805

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3803/head:pr_3803 && git checkout pr_3803
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.41.0-dev-c3d5f1e-amd64

markmandel
markmandel reviewed May 1, 2024
View reviewed changes
pkg/sdkserver/sdkserver.go Outdated Show resolved Hide resolved
pkg/sdkserver/sdkserver.go Show resolved Hide resolved
@igooch igooch force-pushed the inPlaceUpgrades branch from 96e69e4 to 1a1b28e Compare May 2, 2024 19:54
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c3525962-6b06-438f-998a-08d01ff10994

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

zmerlynn
zmerlynn approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@zmerlynn zmerlynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you need to fix a conflict before merging but happy to approve so you can get it in queue after that.

@igooch igooch force-pushed the inPlaceUpgrades branch from a8b20ed to bc1d31e Compare May 3, 2024 16:28
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 5deb4e5d-c004-4069-bc1e-96d3d206f2f0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 331ab084-f45d-44cd-9948-53e75a935fe7

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

igooch added 13 commits May 6, 2024 16:08
@igooch
Changes UpdateLabels to Patch instead of Update
4704795
@igooch
SDK update Counters to use Patch instead of Update
8ae643d
@igooch
SDK update Lists uses Patch instead of Update
9fa9f36
@igooch
SDK update annotations and state uses Patch instead of Update
f3de6b8
@igooch
Changes AssertEqual on a time for AssertWithinDuration of 1 second
ca342b0
@igooch
Adds copy of game server to TestSDKServerReserveTimeout patch reactor
1c09e14
@igooch
Pulls out game server patch into helper function
b2c80d4
@igooch
Changes the SDK role binding permission from Update to Patch
bd5d105
@igooch
SDK server update PlayerTracking to patch
d802346
@igooch
Unexports helper function
5d3d8c8
@igooch
Update game server Patch to fail if the resource version is changed o…
eaac362 
…r not set
@igooch
Adds e2e test for game server patch
5515ea2
@igooch
Increases the SDKServerReserveTimeout tolerance for difference betwee…
6f68262 
…n when the game server is reserved to when the test checks that the game server has been reserved from 1 second to 1.5 seconds
@igooch igooch force-pushed the inPlaceUpgrades branch from cf159a2 to 6f68262 Compare May 6, 2024 16:08
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: a4337993-958e-4f9c-a36d-adfa34651d7a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the inPlaceUpgrades branch from 85f0b88 to 9f0dc0d Compare May 6, 2024 17:05
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: b230f09c-a4ef-41c1-89fb-dbefca2f4ff3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member

Checking different GKE versions, I'm seeing all kinds of weird e2e tests - something has gone unfortunately skewiff.

For example: https://console.cloud.google.com/cloud-build/builds/8456e5b8-41a1-4f9d-806a-5376be6f9570?project=258182270954

I see a bunch of counter issues:

VERBOSE: === RUN   TestCounters/IncrementCounter
VERBOSE: time="2024-05-06 18:13:00.950" level=info msg=IncrementCounter fields.msg="INCREMENT_COUNTER foo 10"
VERBOSE: time="2024-05-06 18:13:00.967" level=info msg="Sending GetCounterCount" fields.msg="GET_COUNTER_COUNT foo"
VERBOSE:     gameserver_test.go:1481: 
VERBOSE:         	Error Trace:	/go/src/agones.dev/agones/test/e2e/gameserver_test.go:1481
VERBOSE:         	Error:      	Not equal: 
VERBOSE:         	            	expected: "COUNTER: 20\n"
VERBOSE:         	            	actual  : "COUNTER: 10\n"
VERBOSE:         	            	
VERBOSE:         	            	Diff:
VERBOSE:         	            	--- Expected
VERBOSE:         	            	+++ Actual
VERBOSE:         	            	@@ -1,2 +1,2 @@
VERBOSE:         	            	-COUNTER: 20
VERBOSE:         	            	+COUNTER: 10
VERBOSE:         	            	 
VERBOSE:         	Test:       	TestCounters/IncrementCounter
VERBOSE: --- FAIL: TestCounters/IncrementCounter (0.04s)
VERBOSE: --- FAIL: TestCounters (3.25s)

@igooch
Copy link
Collaborator Author

igooch commented May 7, 2024

Checking different GKE versions, I'm seeing all kinds of weird e2e tests - something has gone unfortunately skewiff.

That's what I'm working on debugging now. From what logs I've been able to glean it looks like the patch is not going through due to the object resource version having changed (WAI). I'm attempting to figure out if it's failing because it's returning the original error before retry, failing after multiple retries, or something else. Having a hard time debugging since I don't have any easy way of getting the container logs during test since only about one out of twenty game servers fail and there's so much pod churn. I.e. kubectl logs -f -l agones.dev/role=gameserver -c agones-gameserver-sidecar -n 123456 will only get for the currently running pods, and won't watch / stream for newly created pods.

If you know how to create a kubectl command to watch and stream logs for newly created pods in a namespace, please let me know. I haven't been able to get kubectl get pods watch + xargs kubectl logs to work.

@markmandel
Copy link
Member

If you can output to the test which GameServers fail, you should be able to use Cloud Console logging to see all the logs for that Pod and it's sidecars.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ae5dbc53-9735-4951-b4f3-3dae91c47164

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3803/head:pr_3803 && git checkout pr_3803
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.41.0-dev-630250c-amd64

markmandel
markmandel approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@markmandel markmandel merged commit ae030c9 into googleforgames:main May 8, 2024
4 checks passed
spiceratops referenced this pull request in spiceratops/k8s-gitops Jun 8, 2024
@spiceratops
feat(helm): update chart agones to 1.41.0 (#790)
bc2dcf4 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [agones](https://agones.dev)
([source](https://github.com/googleforgames/agones)) | minor |
`1.40.0` -> `1.41.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>googleforgames/agones (agones)</summary>

###
[`v1.41.0`](https://github.com/googleforgames/agones/blob/HEAD/CHANGELOG.md#v1410-2024-06-04)

[Compare
Source](https://github.com/googleforgames/agones/compare/v1.40.0...v1.41.0)

[Full
Changelog](https://github.com/googleforgames/agones/compare/v1.40.0...v1.41.0)

**Implemented enhancements:**

- Configure Allocator Status Code by
[@&#8203;Kalaiselvi84](https://github.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3782](https://github.com/googleforgames/agones/pull/3782)
- Graduate Counters and Lists to Beta by
[@&#8203;Kalaiselvi84](https://github.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3801](https://github.com/googleforgames/agones/pull/3801)
- Passthrough autopilot - Adds an AutopilotPassthroughPort Feature Gate
and new pod label by [@&#8203;vicentefb](https://github.com/vicentefb)
in
[https://github.com/googleforgames/agones/pull/3809](https://github.com/googleforgames/agones/pull/3809)
- CountsAndLists: Move to Beta Protobuf by
[@&#8203;Kalaiselvi84](https://github.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3806](https://github.com/googleforgames/agones/pull/3806)
- feat: support multiple port ranges by
[@&#8203;nrwiersma](https://github.com/nrwiersma) in
[https://github.com/googleforgames/agones/pull/3747](https://github.com/googleforgames/agones/pull/3747)
- Changes `sdk-server` to Patch instead of Update by
[@&#8203;igooch](https://github.com/igooch) in
[https://github.com/googleforgames/agones/pull/3803](https://github.com/googleforgames/agones/pull/3803)
- Generate grpc for nodejs from alpha to beta by
[@&#8203;lacroixthomas](https://github.com/lacroixthomas) in
[https://github.com/googleforgames/agones/pull/3825](https://github.com/googleforgames/agones/pull/3825)
- Update CountsAndLists from Alpha to Beta by
[@&#8203;Kalaiselvi84](https://github.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3824](https://github.com/googleforgames/agones/pull/3824)
- feat(gameserver): New DirectToGameServer PortPolicy allows direct
traffic to a GameServer by
[@&#8203;daniellee](https://github.com/daniellee) in
[https://github.com/googleforgames/agones/pull/3807](https://github.com/googleforgames/agones/pull/3807)
- Passthrough autopilot - Adds mutating webhook by
[@&#8203;vicentefb](https://github.com/vicentefb) in
[https://github.com/googleforgames/agones/pull/3833](https://github.com/googleforgames/agones/pull/3833)
- Passthrough autopilot - added ports array case and updated unit tests
by [@&#8203;vicentefb](https://github.com/vicentefb) in
[https://github.com/googleforgames/agones/pull/3842](https://github.com/googleforgames/agones/pull/3842)
- Nodejs counters and lists by
[@&#8203;steven-supersolid](https://github.com/steven-supersolid) in
[https://github.com/googleforgames/agones/pull/3726](https://github.com/googleforgames/agones/pull/3726)
- Promote AutopilotPassthroughPort feature gate to Alpha by
[@&#8203;vicentefb](https://github.com/vicentefb) in
[https://github.com/googleforgames/agones/pull/3849](https://github.com/googleforgames/agones/pull/3849)

**Fixed bugs:**

- Helm Param Update: Default to agones.controller if agones.extensions
is Missing by [@&#8203;Kalaiselvi84](https://github.com/Kalaiselvi84)
in
[https://github.com/googleforgames/agones/pull/3773](https://github.com/googleforgames/agones/pull/3773)
- fix: rollout strategy issues by
[@&#8203;nrwiersma](https://github.com/nrwiersma) in
[https://github.com/googleforgames/agones/pull/3762](https://github.com/googleforgames/agones/pull/3762)
- Set Minimum Buffer Size to 1 by
[@&#8203;Kalaiselvi84](https://github.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3749](https://github.com/googleforgames/agones/pull/3749)
- Pin ltsc2019 to older SHA by
[@&#8203;zmerlynn](https://github.com/zmerlynn) in
[https://github.com/googleforgames/agones/pull/3829](https://github.com/googleforgames/agones/pull/3829)
- TestGameServerAllocationDuringMultipleAllocationClients: Readdress
flake by [@&#8203;zmerlynn](https://github.com/zmerlynn) in
[https://github.com/googleforgames/agones/pull/3831](https://github.com/googleforgames/agones/pull/3831)
- Refactor finalizer name to include valid domain name and path by
[@&#8203;indexjoseph](https://github.com/indexjoseph) in
[https://github.com/googleforgames/agones/pull/3840](https://github.com/googleforgames/agones/pull/3840)
- agones-{extensions,allocator}: Be more defensive about draining by
[@&#8203;zmerlynn](https://github.com/zmerlynn) in
[https://github.com/googleforgames/agones/pull/3839](https://github.com/googleforgames/agones/pull/3839)
- agones-{extensions,allocator}: Pause after cancelling context by
[@&#8203;zmerlynn](https://github.com/zmerlynn) in
[https://github.com/googleforgames/agones/pull/3843](https://github.com/googleforgames/agones/pull/3843)
- Change the line to modify in Quickstart: Edit a Game Server by
[@&#8203;peterzhongyi](https://github.com/peterzhongyi) in
[https://github.com/googleforgames/agones/pull/3844](https://github.com/googleforgames/agones/pull/3844)

**Other:**

- Prep for Release v1.41.0 by
[@&#8203;Kalaiselvi84](https://github.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3800](https://github.com/googleforgames/agones/pull/3800)
- Update site documentation to reflect firewall prefix and default to
Autopilot cluster creation for Agones by
[@&#8203;vicentefb](https://github.com/vicentefb) in
[https://github.com/googleforgames/agones/pull/3769](https://github.com/googleforgames/agones/pull/3769)
- Add a System Diagram and overview page by
[@&#8203;zmerlynn](https://github.com/zmerlynn) in
[https://github.com/googleforgames/agones/pull/3792](https://github.com/googleforgames/agones/pull/3792)
- Update Side Menu: Preserve and Restore Scroll Position by
[@&#8203;Kalaiselvi84](https://github.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3805](https://github.com/googleforgames/agones/pull/3805)
- fix: typo by [@&#8203;skmpf](https://github.com/skmpf) in
[https://github.com/googleforgames/agones/pull/3808](https://github.com/googleforgames/agones/pull/3808)
- Helm Config: Add httpUnallocatedStatusCode in Allocator Service by
[@&#8203;Kalaiselvi84](https://github.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3802](https://github.com/googleforgames/agones/pull/3802)
- Update Docs: CountersAndLists to Beta by
[@&#8203;Kalaiselvi84](https://github.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3810](https://github.com/googleforgames/agones/pull/3810)
- Disable Dev feature FeatureAutopilotPassthroughPort by
[@&#8203;vicentefb](https://github.com/vicentefb) in
[https://github.com/googleforgames/agones/pull/3815](https://github.com/googleforgames/agones/pull/3815)
- Disable FeatureAutopilotPassthroughPort in features.go by
[@&#8203;vicentefb](https://github.com/vicentefb) in
[https://github.com/googleforgames/agones/pull/3816](https://github.com/googleforgames/agones/pull/3816)
- SDK proto compatibility guarantees and deprecation policies
documentation by [@&#8203;igooch](https://github.com/igooch) in
[https://github.com/googleforgames/agones/pull/3774](https://github.com/googleforgames/agones/pull/3774)
- Fix dangling "as of" by
[@&#8203;zmerlynn](https://github.com/zmerlynn) in
[https://github.com/googleforgames/agones/pull/3827](https://github.com/googleforgames/agones/pull/3827)
- Steps to Promote SDK Features from Alpha to Beta by
[@&#8203;Kalaiselvi84](https://github.com/Kalaiselvi84) in
[https://github.com/googleforgames/agones/pull/3814](https://github.com/googleforgames/agones/pull/3814)
- Adds comment for help troubleshooting issues with terraform tfstate by
[@&#8203;igooch](https://github.com/igooch) in
[https://github.com/googleforgames/agones/pull/3822](https://github.com/googleforgames/agones/pull/3822)
- docs: improve counter and list example comments by
[@&#8203;yonbh](https://github.com/yonbh) in
[https://github.com/googleforgames/agones/pull/3818](https://github.com/googleforgames/agones/pull/3818)
- Skip /tmp/ on yamllint by
[@&#8203;zmerlynn](https://github.com/zmerlynn) in
[https://github.com/googleforgames/agones/pull/3838](https://github.com/googleforgames/agones/pull/3838)
- TestAllocatorAfterDeleteReplica: More logging by
[@&#8203;zmerlynn](https://github.com/zmerlynn) in
[https://github.com/googleforgames/agones/pull/3837](https://github.com/googleforgames/agones/pull/3837)
- Instructions for upgrading golang version by
[@&#8203;gongmax](https://github.com/gongmax) in
[https://github.com/googleforgames/agones/pull/3819](https://github.com/googleforgames/agones/pull/3819)
- Remove unused function FindGameServerContainer by
[@&#8203;zmerlynn](https://github.com/zmerlynn) in
[https://github.com/googleforgames/agones/pull/3841](https://github.com/googleforgames/agones/pull/3841)
- Adds Unreal to the List of URL Links to Not Check by
[@&#8203;igooch](https://github.com/igooch) in
[https://github.com/googleforgames/agones/pull/3847](https://github.com/googleforgames/agones/pull/3847)
- docs: clarify virtualization setup for Windows versions by
[@&#8203;andresromerodev](https://github.com/andresromerodev) in
[https://github.com/googleforgames/agones/pull/3850](https://github.com/googleforgames/agones/pull/3850)

**New Contributors:**

- [@&#8203;skmpf](https://github.com/skmpf) made their first
contribution in
[https://github.com/googleforgames/agones/pull/3808](https://github.com/googleforgames/agones/pull/3808)
- [@&#8203;yonbh](https://github.com/yonbh) made their first
contribution in
[https://github.com/googleforgames/agones/pull/3818](https://github.com/googleforgames/agones/pull/3818)
- [@&#8203;peterzhongyi](https://github.com/peterzhongyi) made their
first contribution in
[https://github.com/googleforgames/agones/pull/3844](https://github.com/googleforgames/agones/pull/3844)
- [@&#8203;andresromerodev](https://github.com/andresromerodev) made
their first contribution in
[https://github.com/googleforgames/agones/pull/3850](https://github.com/googleforgames/agones/pull/3850)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5MC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9taW5vciJdfQ==-->
@daniellee daniellee mentioned this pull request Aug 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmerlynn zmerlynn zmerlynn approved these changes

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
kind/feature New features for Agones size/L size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@igooch @agones-bot @zmerlynn @markmandel