-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve counter and list example comments #3818
Merged
markmandel
merged 17 commits into
googleforgames:main
from
yonbh:docs/improved-counter-list-example-comments
May 24, 2024
Merged
Changes from 14 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
5b1d351
docs: improve counter and list example comments
yonbh a5a351b
fix: indent
yonbh 1716e09
docs: consistency of counter and list comments between example and re…
yonbh 188f491
docs: tidy up counter and list spec comments and make consistent exam…
yonbh c9bed05
fix: linter requests
yonbh 1c236a3
feat: make rooms and players example more consistent and remove sessions
yonbh a18523e
Merge remote-tracking branch 'upstream/main' into docs/improved-count…
yonbh d1e3337
feat: remove more sessions mentions and use rooms for counter only
yonbh 4afdf72
fix: adapt to new templated fleet reference file and make rooms as co…
yonbh e6685e1
feat: make fleet reference for player lists more consistent with coun…
yonbh 804c5a2
fix: rooms as counters
yonbh f2d0b03
feat: use rooms as couters and remove sessions in reference for games…
yonbh 2abdb60
fix: indentation
yonbh a2d37c5
feat: add dot
yonbh 07e491d
docs: reintroduced more examples for counters and lists
yonbh 0362020
docs: reuse 333 as capacity value for rooms list
yonbh b7497b9
fix: linter issue
yonbh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good catch! Thank you! Got that in the examples.yaml, but not here.
https://github.com/googleforgames/agones/blob/main/examples/fleet.yaml has been updated with the move to beta -- but can we make the descriptions match across both (particularly the "available capacity" addition ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback! Changed in 1716e09.
Added the Beta information and made the descriptions in fleet.yaml and fleet.md more consistent.