feat: Add CRD Changes and Feature Flag for chain policy

[indexjoseph]

What type of PR is this?

/kind feature

What this PR does / Why we need it:
New Chain Policy for Scheduled Autoscaling, see this comment for more info: comment

Which issue(s) this PR fixes:
Towards #3008

Special notes for your reviewer:

[github-actions]

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

[agones-bot]

Build Failed 😱

Build Id: 400ce682-b083-4f58-91a9-d32f9d48b6ce

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[github-actions]

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

[agones-bot]

Build Failed 😱

Build Id: aab7f190-0879-4b03-8390-90bc8f85a610

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[zmerlynn]

A couple of things:

1. This should be under a feature gate, including the CRD addition (the refactor portion should be fine, but the new additions should be gated). See here for how to add a gate: https://github.com/googleforgames/agones/blob/main/pkg/util/runtime/features.go#L85 .. but also, you can gate helm values, see

   agones/install/helm/agones/templates/controller.yaml

   Lines 118 to 119 in 1f6b2a0

   	{{- $featureGates := include "agones.featureGates" . | fromYaml }}
   	{{- if not $featureGates.PortRanges }}

   for a recent example. Doing all of this under a dev feature gate will allow you to send smaller PRs without it all being ready for testing yet.
2. Split this up into smaller PRs - feel free to submit the validation separate from the CRD itself, since they're both big hunks to review.

[github-actions]

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

[agones-bot]

Build Failed 😱

Build Id: 8db36c7c-204e-4960-b4a1-e6522102f1a8

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Failed 😱

Build Id: c35a15cf-dfce-4e97-9e4e-6e60ebdb5ff4

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Failed 😱

Build Id: b580612f-a992-4f15-847f-c66660edaa69

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Succeeded 👏

Build Id: e5b70ed5-2ca7-4494-bcfb-d25c47fed13e

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.42.0-dev-bf4b616-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.42.0-dev-bf4b616-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.42.0-dev-bf4b616-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.42.0-dev-bf4b616-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.42.0-dev-bf4b616-amd64
• Linux C++ SDK (build): agonessdk-1.42.0-dev-bf4b616-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.42.0-dev-bf4b616-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://bf4b616-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3880/head:pr_3880 && git checkout pr_3880
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.42.0-dev-bf4b616-amd64

[agones-bot]

Build Succeeded 👏

Build Id: bf88ff90-81b7-4469-8ed1-137103bf2a9d

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.42.0-dev-f494f3c-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.42.0-dev-f494f3c-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.42.0-dev-f494f3c-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.42.0-dev-f494f3c-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.42.0-dev-f494f3c-amd64
• Linux C++ SDK (build): agonessdk-1.42.0-dev-f494f3c-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.42.0-dev-f494f3c-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://f494f3c-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3880/head:pr_3880 && git checkout pr_3880
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.42.0-dev-f494f3c-amd64

[agones-bot]

Build Failed 😱

Build Id: f9a0471d-b216-4045-a687-06fe3c865d24

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Failed 😱

Build Id: d4beaa90-e177-4d79-b408-88b8c3344d3f

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Succeeded 👏

Build Id: e2793105-fe2f-4579-93cf-144666a022a9

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.42.0-dev-13e4e77-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.42.0-dev-13e4e77-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.42.0-dev-13e4e77-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.42.0-dev-13e4e77-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.42.0-dev-13e4e77-amd64
• Linux C++ SDK (build): agonessdk-1.42.0-dev-13e4e77-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.42.0-dev-13e4e77-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://13e4e77-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3880/head:pr_3880 && git checkout pr_3880
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.42.0-dev-13e4e77-amd64

[github-actions]

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

[agones-bot]

Build Failed 😱

Build Id: a9fcd094-59d4-4f16-b542-1786ac8c878a

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Succeeded 👏

Build Id: 11f4dff3-cbb3-4aca-8d51-c27835709d93

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.42.0-dev-c96d80b-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.42.0-dev-c96d80b-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.42.0-dev-c96d80b-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.42.0-dev-c96d80b-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.42.0-dev-c96d80b-amd64
• Linux C++ SDK (build): agonessdk-1.42.0-dev-c96d80b-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.42.0-dev-c96d80b-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://c96d80b-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3880/head:pr_3880 && git checkout pr_3880
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.42.0-dev-c96d80b-amd64

[zmerlynn]

If there's a second or redundant comment, I'm sorry - I see I have two review comments but can only see one.

[agones-bot]

Build Succeeded 👏

Build Id: 7035dff9-fcc5-4a49-9b39-3b6e74a3f0cb

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.42.0-dev-59c4259-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.42.0-dev-59c4259-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.42.0-dev-59c4259-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.42.0-dev-59c4259-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.42.0-dev-59c4259-amd64
• Linux C++ SDK (build): agonessdk-1.42.0-dev-59c4259-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.42.0-dev-59c4259-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://59c4259-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3880/head:pr_3880 && git checkout pr_3880
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.42.0-dev-59c4259-amd64

[zmerlynn]

Awesome!

[agones-bot]

Build Succeeded 👏

Build Id: dd93fdcd-8b19-4d12-82f7-348aaee568b7

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.42.0-dev-6a49905-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.42.0-dev-6a49905-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.42.0-dev-6a49905-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.42.0-dev-6a49905-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.42.0-dev-6a49905-amd64
• Linux C++ SDK (build): agonessdk-1.42.0-dev-6a49905-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.42.0-dev-6a49905-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://6a49905-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3880/head:pr_3880 && git checkout pr_3880
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.42.0-dev-6a49905-amd64