Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unreal SDK - Add Support for GameServer Status Addresses #3932

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Unreal SDK - Add Support for GameServer Status Addresses #3932

merged 3 commits into from
Sep 9, 2024

Conversation

KAllan357
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix
/kind release

What this PR does / Why we need it:

When we first started using Agones, we noticed this was a missing feature of the Unreal SDK.

We've been using this code in our development clusters to dynamically pick an Address from the GameServer Status Addresses part of the JSON response for a few months now. We use it in conjunction with a Tailscale subnet router to connect directly to the PodIP using the PortPolicyNone feature.

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@github-actions github-actions bot added kind/feature New features for Agones size/S labels Aug 2, 2024
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 6cb4bc25-dc68-45a9-ba72-4c250504f395

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3932/head:pr_3932 && git checkout pr_3932
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-98abc95

@KAllan357 KAllan357 force-pushed the unreal-sdk/status-addresses branch from 98abc95 to 54b06b2 Compare August 20, 2024 13:21
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: d9fa0e8b-81ba-42d6-9c88-01acbd71890f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3932/head:pr_3932 && git checkout pr_3932
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-54b06b2

@KAllan357
Copy link
Contributor Author

@markmandel I know the project is missing an Unreal expert, so I was wondering how something like this could get reviewed and merged?

@igooch
Copy link
Collaborator

igooch commented Aug 26, 2024

@GloryOfNight given that it looks like you use Unreal would you be able to validate the changes in this PR?

@markmandel
Copy link
Member

@markmandel I know the project is missing an Unreal expert, so I was wondering how something like this could get reviewed and merged?

Sorry for the lack of reply -- been travelling for Devcom/Gamescom -- but you are in good hands with @igooch !

@KAllan357 KAllan357 force-pushed the unreal-sdk/status-addresses branch from 54b06b2 to c344bd4 Compare August 27, 2024 12:52
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: f6c03e21-2fd1-4cf6-b92c-8d7d848064cf

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3932/head:pr_3932 && git checkout pr_3932
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-c344bd4

@KAllan357 KAllan357 force-pushed the unreal-sdk/status-addresses branch from c344bd4 to 6afdcc2 Compare August 29, 2024 15:15
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 281728c6-1df5-44d1-b9cc-7c53e833509f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3932/head:pr_3932 && git checkout pr_3932
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-6afdcc2

@KAllan357
Copy link
Contributor Author

@igooch looks like @GloryOfNight added a +1

@KAllan357 KAllan357 force-pushed the unreal-sdk/status-addresses branch from 6afdcc2 to 41884d2 Compare September 5, 2024 13:08
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 8fe0c858-32da-4f79-ba1f-1d57ba885dbb

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3932/head:pr_3932 && git checkout pr_3932
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.44.0-dev-41884d2

igooch
igooch approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution. LGTM per approval from @GloryOfNight.

@igooch igooch enabled auto-merge (squash) September 9, 2024 04:23
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 10844244-9353-438d-9742-4b34020b1668

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3932/head:pr_3932 && git checkout pr_3932
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.44.0-dev-8e44c25

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 7ecdfff5-fe6e-4262-8d6b-519170e80087

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3932/head:pr_3932 && git checkout pr_3932
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.44.0-dev-5f48ea7

@igooch igooch merged commit 59076bc into googleforgames:main Sep 9, 2024
4 checks passed
@KAllan357 KAllan357 deleted the unreal-sdk/status-addresses branch September 30, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GloryOfNight GloryOfNight GloryOfNight approved these changes

@igooch igooch igooch approved these changes

Assignees
No one assigned
Labels
kind/feature New features for Agones size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KAllan357 @agones-bot @igooch @markmandel @GloryOfNight