Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreal SDK - Added counters to unreal sdk #3935

Merged
merged 14 commits into from
Sep 6, 2024
Merged

Unreal SDK - Added counters to unreal sdk #3935

merged 14 commits into from
Sep 6, 2024

Conversation

GloryOfNight
Copy link
Contributor

@GloryOfNight GloryOfNight commented Aug 8, 2024

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix
/kind release

What this PR does / Why we need it:
Added counters to unreal sdk

Which issue(s) this PR fixes:
n/a

Closes #3648 (partially)

Special notes for your reviewer:

Validity of http requests not tested.
Build log as requested in CONTRIBUTING.md:

buildWin64Editor.log

Copy link

google-cla bot commented Aug 8, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added kind/feature New features for Agones size/M labels Aug 8, 2024
@GloryOfNight GloryOfNight marked this pull request as draft August 8, 2024 21:10
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 01fbce8a-8930-430b-845b-454f9acc8cb4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3935/head:pr_3935 && git checkout pr_3935
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-d8e45eb

@GloryOfNight GloryOfNight marked this pull request as ready for review August 9, 2024 09:01
@GloryOfNight
Copy link
Contributor Author

buildWin64Editor.log

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: b480c9f0-481a-4ef5-aaf5-b76e25478735

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 13a8808e-11a7-4104-9cfe-db4a4cbbce36

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3935/head:pr_3935 && git checkout pr_3935
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-c6ec608

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 74231d6b-3a0a-49cc-b5b1-12f866cbbd87

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3935/head:pr_3935 && git checkout pr_3935
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-98b4524

@igooch
Copy link
Collaborator

igooch commented Aug 20, 2024

@tvandijck and @KiaArmani as the most recent contributors to the Unreal SDK, would you review this PR?

@zifter
Copy link
Contributor

zifter commented Aug 26, 2024

Any updates? It would be great to have it in 1.43 :)

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 54dafa02-7d35-4c2e-b255-65007ec87795

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3935/head:pr_3935 && git checkout pr_3935
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-bdd95e1

@igooch
Copy link
Collaborator

igooch commented Aug 26, 2024

Any updates? It would be great to have it in 1.43 :)

1.43 release is getting cut in a few hours, so it's probably too close for this release.

@zifter or @KAllan357 would you be able to test and validate the changes in this PR?

@zifter
Copy link
Contributor

zifter commented Aug 26, 2024

@igooch I'm working with @GloryOfNight in the same company and these changes are made by my request.

I actually can confirm, that it's tested, because we are using those changes currently in production.

@GloryOfNight
Copy link
Contributor Author

We only using counter decrement. Get/Set Counter is not tested.
I'll give some time to test them to be sure.

Copy link
Contributor

@KiaArmani KiaArmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Found an issue with default initialized content string that by default {} (braces). That caused Get req. to fail.
@GloryOfNight
Copy link
Contributor Author

GloryOfNight commented Aug 27, 2024

Tested, found issue with GetCounters() call related to default initialized content string as braces. Fixed it.
Everything looks good now.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 9c33eb73-b894-4fca-8c1c-d50494d4ff84

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3935/head:pr_3935 && git checkout pr_3935
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-b8b37c8

Copy link
Contributor

@zifter zifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 9e937153-a4eb-4f57-900c-c909794b5c77

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3935/head:pr_3935 && git checkout pr_3935
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-25ac6d3

@zifter
Copy link
Contributor

zifter commented Sep 6, 2024

Any updates?

Copy link
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on reviews by @KiaArmani and @zifter. Thank you for the contribution!

@igooch igooch enabled auto-merge (squash) September 6, 2024 16:34
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: a435d9bc-db09-4eb1-9577-ff4e14b46998

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3935/head:pr_3935 && git checkout pr_3935
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.44.0-dev-c5fa1c9

@igooch igooch merged commit 0625ae5 into googleforgames:main Sep 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New features for Agones size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unreal CountsAndLists SDK implementation
5 participants