Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting code with gofmt #4000

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Formatting code with gofmt #4000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4bc927c
Formatting code with gofmt
cuishuang Sep 25, 2024
3b1c678
Merge branch 'main' into main
gongmax Sep 30, 2024
57e5e54
Merge branch 'main' into main
gongmax Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmd/controller/pprof.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

//go:build profile
// +build profile
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This serves the same purpose of line 15, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, currently both serve the same purpose. //go:build xxx is the new recommended syntax introduced in Go 1.17, and gofmt will automatically add it when // +build is present without //go:build.

For more details, please refer to this link.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering whether we can remove the // +build profile

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My opinion is that if someone builds with a version lower than go 1.17, I think there will be issues. Because early versions of Go did not have this feature. So for better compatibility, both can be retained


package main
Expand Down
1 change: 1 addition & 0 deletions cmd/extensions/pprof.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

//go:build profile
// +build profile

package main
Expand Down
Loading