Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shutdown Delay Seconds to the sdk-client-test containers #4030

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Nov 5, 2024

What type of PR is this?

/kind feature

What this PR does / Why we need it:

Adds dynamic shutdown delay and graceful termination delay to the sdk-client-test. The will allow the user to dynamically set delays when creating a game server without needing to rebuild the container. These delays are important for preventing Game Servers from churning too quickly on a running cluster.

This will not affect the current conformance test that uses this test as the defaults are 0 for both delays.

Which issue(s) this PR fixes:

Working on #3795

Special notes for your reviewer:

@github-actions github-actions bot added kind/feature New features for Agones size/S labels Nov 5, 2024
@gongmax gongmax enabled auto-merge (squash) November 5, 2024 23:44
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: ffcb7fcf-8830-46c0-830c-16c7c4fc128e

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 39b0833c-a91f-4709-b420-6d61a56e28fa

Status: TIMEOUT

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: b68cae22-c26f-4b29-8ea1-f76067d1165f

Status: TIMEOUT

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 8c8b964e-bf79-4ea2-b808-b1ddc4933a15

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4030/head:pr_4030 && git checkout pr_4030
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.45.0-dev-3f370ed

@gongmax gongmax merged commit 6d36d20 into googleforgames:main Nov 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New features for Agones size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants