Add Agones version into Gameserver Annotation #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Failed 😱 Build Id: 02c37e2c-a16b-4412-9e1e-e085795d6291 Build Logs |
|
Build Failed 😱 Build Id: 5201268e-fef6-4790-9e52-8c2d5576b692 Build Logs |
markmandel
reviewed
Jan 24, 2019
There was a problem hiding this comment.
Added a small improvement I'd like to see.
@victor-prodan - this was your original issue - anything else you would like to see here? 😄
pkg/apis/stable/v1alpha1/fleet.go
Outdated
| @@ -25,6 +26,9 @@ const ( | |||
| // FleetNameLabel is the label that the name of the Fleet | |||
| // is set to on GameServerSet and GameServer the Fleet controls | |||
| FleetNameLabel = stable.GroupName + "/fleet" | |||
| // FleetSdkVersionAnnotation is the key for version annotation | |||
| // associated with the Fleet | |||
| FleetSdkVersionAnnotation = stable.GroupName + "/sdk-version" | |||
There was a problem hiding this comment.
Since this is the same everywhere, should we just have one central VersionAnnotation value?
|
This is what I wanted, thanks for implementing it! |
|
Build Succeeded 👏 Build Id: ce0a95a2-adbd-45e4-a2a4-8c470867f242 The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
|
Build Succeeded 👏 Build Id: 654fc6c1-f4f1-4eab-8c3b-21197012950e The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
|
Just a gentle bump - if you switch this to a using a central (Just trying to clear out PRs 😄 ) |
markmandel
added
kind/feature
|
Build Failed 😱 Build Id: b384df91-daf7-4327-a56d-fbe102596122 Build Logs |
Add sdk-version annotation into Gameserver and Pod spec.
|
Build Succeeded 👏 Build Id: 94049346-270f-426e-95d2-eaceac17fb20 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website will exist for the next 30 days: To install this version:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "stable.agones.dev/sdk-version" annotation into Gameserver CRD and Pod specification as well as Fleet CRD. So that Sidecar can be retrieved using WatchGameServer() callback.
Covers #310 As a game server, I want to get the Agones sidecar version.