Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitoring improvements #559

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Monitoring improvements #559

merged 1 commit into from
Feb 4, 2019

Conversation

jkowalski
Copy link
Contributor

  • excluded system nodes (tainted with stable.agones.dev/*) from GS/node census
  • fixed distribution buckets to account for the fact that OpenCensus uses buckets with "<" while Prometheus uses "<=", so there's no way to properly count nodes with zero gameservers
  • fixed grafana dashboard gameservers/node ("avg")
  • reduced rate window for gameservers/node from 5m to 1m

@jkowalski jkowalski requested a review from cyriltovena February 4, 2019 22:43
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 069ac678-0c01-44cc-9961-435f8fa11307

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@jkowalski
Monitoring improvements:
1d9fd20 
- excluded system nodes (tainted with stable.agones.dev/*) from GS/node census
- fixed distribution buckets to account for the fact that OpenCensus uses buckets with "<" while Prometheus uses "<=", so there's no way to properly count nodes with zero gameservers
- fixed grafana dashboard gameservers/node ("avg")
- reduced rate window for gameservers/node from 5m to 1m
@jkowalski jkowalski force-pushed the monitoring-improvements branch from 9f82263 to 1d9fd20 Compare February 4, 2019 22:51
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0b5853f9-f69a-42eb-b11d-fd1e15e62626

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website will exist for the next 30 days:

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/559/head:pr_559 && git checkout pr_559
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-1d9fd20

@cyriltovena cyriltovena merged commit bc94c9a into googleforgames:master Feb 4, 2019
@jkowalski jkowalski deleted the monitoring-improvements branch February 4, 2019 23:16
@markmandel markmandel added kind/feature New features for Agones area/operations Installation, updating, metrics etc labels Feb 5, 2019
@markmandel markmandel added this to the 0.8.0 milestone Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
area/operations Installation, updating, metrics etc kind/feature New features for Agones
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jkowalski @agones-bot @cyriltovena @markmandel