Remove destination address allocation #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jake-Shadle
requested review from
markmandel,
XAMPPRocky and
koslib
as code owners
Due to gxhash, these flags are required to be able to compile, so just set them once rather than requiring passing RUSTFLAGS
This removes a heap allocation done for every downstream packet that uses eg. tokenrouter so that it can be allocated (usually) just once and reused
Jake-Shadle
force-pushed
the
remove-filter-allocation
branch
from
b325b95 to
c669e9b
Compare
|
Build Succeeded 🥳 Build Id: 709173cd-1459-4537-8707-b5bdcc34b028 The following development images have been built, and will exist for the next 30 days: To build this version: |
XAMPPRocky
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the unnecessary heap allocation for the destination address(es) for downstream packets by just making it a mutable reference that is passed from the packet router driver.