Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky tests on CI #174

Closed
arriolac opened this issue Jul 12, 2022 · 4 comments · Fixed by #180
Closed

Fix flaky tests on CI #174

arriolac opened this issue Jul 12, 2022 · 4 comments · Fixed by #180
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. released type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@arriolac
Copy link
Contributor

arriolac commented Jul 12, 2022

Steps to reproduce

Run the test workflow on main and notice that instrumentation tests are failing. Example failed runs:

https://github.com/googlemaps/android-maps-compose/runs/7306842111
https://github.com/googlemaps/android-maps-compose/runs/7283340731

Also see discussion in #171

Code example

N/A

Stack trace

com.google.maps.android.compose.MapInColumnTests > testScrollColumn_MapCameraRemainsSame[test(AVD) - 10] FAILED 
	java.lang.AssertionError: Assert failed: The component is displayed!
	at androidx.compose.ui.test.AssertionsKt.assertIsNotDisplayed(Assertions.kt:51)
@arriolac arriolac added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. triage me I really want to be triaged. labels Jul 12, 2022
@arriolac
Copy link
Contributor Author

Looks like there are 2 causes for the failed actions linked in the description:

  1. Failure due to secrets not being available on forks. This is the reason for the failed PR in https://github.com/googlemaps/android-maps-compose/runs/7283340731. This should be addressed by chore: Use pull_request_target. #175
  2. Failure in MapInColumnTests.testScrollColumn_MapCameraRemainsSame. This appears to be env specific as running it locally passes. Perhaps running the test on the same emulator might give us some hints on what might be causing the test failure.

@barbeau
Copy link
Contributor

barbeau commented Jul 12, 2022

I tried running locally on this emulator and the tests still pass:

image

This was referenced Jul 12, 2022
@barbeau barbeau mentioned this issue Jul 15, 2022
4 tasks
This was referenced Aug 18, 2022
@wangela wangela added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed triage me I really want to be triaged. labels Oct 21, 2022
@wangela wangela closed this as completed Jan 10, 2023
@wangela
Copy link
Member

wangela commented Mar 15, 2023

Tests cannot pass on PRs from forks. Root cause: community/community#50161

@wangela wangela reopened this Mar 15, 2023
@googlemaps-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.11.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. released type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants