feat: use product in battle #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alko89
commented
Sep 24, 2024
alko89
commented
Sep 24, 2024
|
|
||
| switch (product) { | ||
| case EProduct.HERB: | ||
| attacker.healthPoints += 10; |
There was a problem hiding this comment.
Perhaps scale with product level? 🤔
…ain code logix without selected item before starting fight
alko89
commented
Oct 15, 2024
src/user/schemas/userPvp.schema.ts
Outdated
| getters: true, | ||
| }, | ||
| }) | ||
| export class ActiveEffect { |
There was a problem hiding this comment.
is this schema still needed?
There was a problem hiding this comment.
no it was just an easy way to use the schema instead of using an interface when copying the user pvp object into the pvp battle fixed now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.