Refactor TestValidBrowsers. #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guillermo N. <guillerm0.n@outlook.es>
Signed-off-by: Guillermo N. <guillerm0.n@outlook.es>
dominikschulz
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the
TestValidBrowsersfunction to improve maintainability and avoid potential conflicts in the future.Changes Made:
validBrowserslist based on the operating system (darwin,windows, andlinux) using aswitchstatement.Rationale
A couple of days ago, I tried to help with PR #133, which was eventually fixed by @dominikschulz. At the same time, I came up with this version that I believe solves the problem in a clean way. As an outsider, I think this new version lets you better identify and extend the test for future modifications.