Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mixer
to let it drain when all its streamers have been drained instead of playing silence. I have added this in preparation of an optimization that I would like to do in the speaker to auto-close Oto's player when nothing is being played anymore. edit: may not be relevant anymore.Updated theReverted this change to keep backwards compatibility. I may introduce this change again when we move to v3.Streamer
interface. Now it allows Streamers to use thesamples
passed toSteam()
as scratch space even if it doesn't fill it completely.Mixer
previously didn't adhere to the interface when it said it wasn't allowed to do that. I think programs can be more efficient when Streamers are allowed to do that. This is also how theReader
interface works.Mixer
to replace the implementation forMix()
.Mix()
should work the same as before.Edit:
Resolves #179