Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate method for file/directory metadata modifcation #800

Open
wants to merge 43 commits into
base: master
Choose a base branch
from

Conversation

GreatBahram
Copy link

Hi there,

As we discussed here #260, I tried to solve the problem using two new events for inotify, kqueue, and fsevents2 backends. So far, I've found no solution for the windows, as in this document describes it does not have an action for this purpose.

To be able to run it manually, currently it only works when you send a pull_request
@GreatBahram
Copy link
Author

Hi @BoboTiG,

Could you approve my workflows, please?

I changed the fsevents and fsevents2 modules, but I'm still unsure of them. The GitHub actions is very primitive; I could not get any guarantee out of it. But for inofity and kqueue, I tested them manually on Linux and Freebsd.

I’m eager to receive your feedback.

@GreatBahram
Copy link
Author

The pipeline gives a bizarre error message. Do you know what the reason is?

OSError: [Errno 9] Bad file descriptor

@BoboTiG
Copy link
Collaborator

BoboTiG commented Mar 18, 2023

@GreatBahram I fixed conflicts, and rebased from master. Would you be able to double check I didn't alter what you've done in tests + fix linting/mypy issues 🙏🏻 ?

@mmguero
Copy link

mmguero commented Apr 6, 2023

Glad to see this PR is still alive, I'd love to see this get pulled.

tests/shell.py Outdated Show resolved Hide resolved
src/watchdog/events.py Show resolved Hide resolved
src/watchdog/events.py Show resolved Hide resolved
src/watchdog/observers/fsevents.py Outdated Show resolved Hide resolved
src/watchdog/observers/fsevents.py Outdated Show resolved Hide resolved
src/watchdog/observers/fsevents.py Outdated Show resolved Hide resolved
@BoboTiG
Copy link
Collaborator

BoboTiG commented Apr 22, 2023

Several Mac, and Windows, tests are failing. I'l try to fix them later. I would like to have that PR merged for the upcoming version.

tests/test_fsevents.py Outdated Show resolved Hide resolved
tests/test_emitter.py Outdated Show resolved Hide resolved
tests/utils.py Show resolved Hide resolved
tests/test_emitter.py Outdated Show resolved Hide resolved
tests/utils.py Outdated Show resolved Hide resolved
@BoboTiG
Copy link
Collaborator

BoboTiG commented Apr 24, 2023

A few remaining macOS tests to fix, and we will be good to merge.

@BoboTiG
Copy link
Collaborator

BoboTiG commented May 14, 2023

I finally have a Mac machine, it will be easier to fix those tests. I'll try to get it done "quickly".

tests/test_emitter.py Outdated Show resolved Hide resolved
tests/test_emitter.py Outdated Show resolved Hide resolved
tests/test_emitter.py Outdated Show resolved Hide resolved
tests/test_emitter.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants