Merge pull request #222 from sideshowcoder/skip-sslip-test-if-sslip-d…

…ns-not-configured Skip sslip.io tests if DNS is not configured
gordalina · Jan 3, 2023 · b54f452 · b54f452
2 parents eedac2f + b6715ad
commit b54f452
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/tests/Adapter/Http/FileGetContentsTest.php b/tests/Adapter/Http/FileGetContentsTest.php
@@ -31,7 +31,13 @@ public function testFetch()
 
     public function testFetchUnderscores()
     {
-        $client = new SymfonyHttpClient('http://_.127.0.0.1.sslip.io:9999');
+        $sslipHostname = '_.127.0.0.1.sslip.io';
+        if (!gethostbynamel($sslipHostname)) {
+            $this->markTestSkipped(
+                "{$sslipHostname} does not resolve, sslip  DNS is not configured correctly, skipping."
+            );
+        }
+        $client = new SymfonyHttpClient("http://{$sslipHostname}:9999");
         $this->assertStringStartsWith('# CacheTool', $client->fetch('README.md'));
     }
 

diff --git a/tests/Adapter/Http/SymfonyHttpClientTest.php b/tests/Adapter/Http/SymfonyHttpClientTest.php
@@ -31,7 +31,13 @@ public function testFetch()
 
     public function testFetchUnderscores()
     {
-        $client = new SymfonyHttpClient('http://_.127.0.0.1.sslip.io:9999');
+        $sslipHostname = '_.127.0.0.1.sslip.io';
+        if (!gethostbynamel($sslipHostname)) {
+            $this->markTestSkipped(
+                "{$sslipHostname} does not resolve, sslip  DNS is not configured correctly, skipping."
+            );
+        }
+        $client = new SymfonyHttpClient("http://{$sslipHostname}:9999");
         $this->assertStringStartsWith('# CacheTool', $client->fetch('README.md'));
     }