Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With Chrome >= 58.x uBlock can handle FULLY itself all websocket "things"? #2478

Closed
Alpengreis opened this issue Mar 24, 2017 · 9 comments
Closed

Comments

@Alpengreis
Copy link

Am I right that with Chrome >= 58.x uBlock can handle FULLY itself all websocket "things" and I do no more need uBlock Extra?

@mapx-
Copy link

mapx- commented Mar 24, 2017

probably "WebSocket opened from the SharedWorker" wont be blocked.
see
https://issues.adblockplus.org/ticket/4770#comment:8

but @gorhill could clear better this question

@Alpengreis
Copy link
Author

Thank you for the link so far, interesting!

@gorhill
Copy link
Owner

gorhill commented Mar 24, 2017

Yes, starting with Chromium 58+ and uBO 1.11.5+, websocket connection attempts will be filtered by uBO itself.

However uBO Extra has become multipurpose, and whether you still need it depends on whether you are a visitor to one of the sites for which uBO-Extra contains special fixes.

@mapx- this is a different issue, this has been addressed in uBO itself with 1.11.2, related issue: #2360. Solution is to prevent the shared worker to be created in the first place using a |blob: filter to decide whether a CSP directive to restrict blob:-based shared workers.

@gorhill
Copy link
Owner

gorhill commented Mar 24, 2017

@Alpengreis can you still confirm that the warning you get in #2435 do not break uBO at all? This is very important. If it's only warnings, then this is an acceptable side effect of supporting ability to block websockets as early as when Chromium 58 is released.

@Hrxn
Copy link

Hrxn commented Mar 24, 2017

However uBO Extra has become multipurpose, and whether you still need it depends on whether you are a visitor to one of the sites for which uBO-Extra contains special fixes.

Is there a list of these sites, to get an overview?

@okiehsch
Copy link
Contributor

They are inside contentscript.js for example sites using Instart Logic
https://github.com/gorhill/uBO-Extra/blob/master/contentscript.js#L272

@Hrxn
Copy link

Hrxn commented Mar 24, 2017

Ah, okay. Thanks. I expected something along the lines of "filters.txt" or "sites.txt" somewhere, not directly in 'contentscript.js'

Well, from the listed sites I only visit pcmag.com semi-regularly, but I don't see any ads there, without uBO-Extra. Is this location-based maybe?

@gorhill
Copy link
Owner

gorhill commented Mar 24, 2017

@Alpengreis
Copy link
Author

Alpengreis commented Mar 24, 2017

@gorhill

Shortly thereafter, I uninstalled Chrome release version. Then I had few days no Chrome and now Chrome Beta (v58.0.3029.33 beta 64-bit), even because that websocket integration (my Browser to really work with is still Fx (now in Developer version).

I had tested that only short anyway and saw it does still block. I had not tested it more. The last version I saw, that uBlock do still block was (without guarantee) perhaps v1.11.5b1 ...

@gorhill gorhill closed this as completed Mar 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants