Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SharedWorker [sibnet.ru] #2360

Closed
dimisa-RUAdList opened this issue Feb 6, 2017 · 11 comments
Closed

SharedWorker [sibnet.ru] #2360

dimisa-RUAdList opened this issue Feb 6, 2017 · 11 comments

Comments

@dimisa-RUAdList
Copy link

dimisa-RUAdList commented Feb 6, 2017

uBO 1.11.0
Google Chrome 56.0.2924.76 (64-bit)
uBlock Filters
EasyList
RU AdList

  1. Disable hiding filters:
    #@#.da_adp_teaser
    #@#.directadvert-block
    sibnet.ru#@##right_place_wrapper
  2. Open http://www.sibnet.ru/ and wait 2-3 seconds
  3. Ads appears at the top of the page.
@gorhill gorhill closed this as completed in a742f09 Feb 6, 2017
@gorhill
Copy link
Owner

gorhill commented Feb 6, 2017

Ideally we should have a new filter such as webworker to accurately filter workers. Currently using the existing |blob:$script ones to decide whether a CSP to prevent blob:-based workers should be injected.

@dimisa-RUAdList
Copy link
Author

Yes, that would be correct.

@ryanbr
Copy link
Contributor

ryanbr commented Feb 6, 2017

blob: can also be an image file, so strictly not just $script

@dimisa-RUAdList
Copy link
Author

@gorhill
Copy link
Owner

gorhill commented Feb 6, 2017

blob: can also be an image file, so strictly not just $script

Sure blob: as URI can represent anything (css, image, media, script, etc.), but since there is no such thing yet as webworker type, using |blob:$script specifically to inject a CSP to forbid workers on a page is better, otherwise now I will have to assume that anything starting with |blob: should result in a CSP being injected, that is not a safe assumption.

We are going to have to come to an agreement about what sort of filter is going to block webworkers.

@gorhill gorhill reopened this Feb 6, 2017
@dimisa-RUAdList
Copy link
Author

While I will not be in a hurry:
https://hg.adblockplus.org/ruadlist/rev/94b4326fdccc

@ryanbr
Copy link
Contributor

ryanbr commented Feb 7, 2017

While I will not be in a hurry:

Keep in mind, it's safe without the $script suffix, in Easylist we've made blob: a generic filter. I haven't see a false positive where a site will use 2 types of blobs (one for an Advert, and for a non-advert).

If I recall the abuse of the blob: was changed from |blob:$script,domain=.. to |blob:$domain= was due to jpost.

@dimisa-RUAdList
Copy link
Author

@ryanbr Keep in mind, it's safe without the $script suffix, in Easylist we've made blob: a generic filter. I haven't see a false positive where a site will use 2 types of blobs (one for an Advert, and for a non-advert).

Unfortunately, it does not work everywhere: http://www.anilibria.tv/release/bernard-jou-iwaku.html
When blocking blobs disrupted video player. I sometimes encounter similar in Firefox.

@gorhill fix #2360

Why was removed uBlock Origin 1.11.1b?

@ryanbr
Copy link
Contributor

ryanbr commented Feb 7, 2017

Is there is some legit cases where allowing blob: is fine, anilibria.tv is such one

@gorhill
Copy link
Owner

gorhill commented Feb 7, 2017

Why was removed uBlock Origin 1.11.1b?

Because it wasn't working anymore when script was removed from the |blob: filter, my implementation was testing for precisely script type.

I gave mores thought to my "not a safe assumption", and I believe it should be ok after all as long as the effects of a generic |blob: filter is well understood, so I re-implemented to work with either script or no specific type, I haven't committed yet.

gorhill added a commit that referenced this issue Feb 7, 2017
@dimisa-RUAdList
Copy link
Author

Clear. But I returned the "script" suffix in RU AdList: https://hg.adblockplus.org/ruadlist/rev/94b4326fdccc
And yes, - blockage in 1.11.1b worked great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants