Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BottomSheetScrollView): Scroll responder types use mixin #1335

Merged
merged 2 commits into from
Apr 30, 2023
Merged

fix(BottomSheetScrollView): Scroll responder types use mixin #1335

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7177d39
fix(BottomSheetScrollView): Scroll responder types use mixin
Mar 31, 2023
45fbd28
chore: removed unused import
gorhom Apr 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/components/bottomSheetScrollable/types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import type {
RefObject,
} from 'react';
import type {
ScrollView,
VirtualizedListProps,
ScrollViewProps,
FlatListProps,
Expand All @@ -15,6 +14,7 @@ import type {
View,
ScrollViewComponent,
NodeHandle,
ScrollResponderMixin,
} from 'react-native';
import type Animated from 'react-native-reanimated';
import type { ScrollEventsHandlersHookType } from '../../types';
Expand Down Expand Up @@ -114,7 +114,7 @@ export interface BottomSheetFlatListMethods {
/**
* Provides a handle to the underlying scroll responder.
*/
getScrollResponder: () => ReactNode | null | undefined;
getScrollResponder: () => ScrollResponderMixin | null | undefined;

/**
* Provides a reference to the underlying host component
Expand Down Expand Up @@ -175,7 +175,7 @@ export interface BottomSheetScrollViewMethods {
* implement this method so that they can be composed while providing access
* to the underlying scroll responder's methods.
*/
getScrollResponder(): ReactNode;
getScrollResponder(): ScrollResponderMixin;

getScrollableNode(): any;

Expand Down Expand Up @@ -231,7 +231,7 @@ export interface BottomSheetSectionListMethods {
/**
* Provides a handle to the underlying scroll responder.
*/
getScrollResponder(): ScrollView | undefined;
getScrollResponder(): ScrollResponderMixin | undefined;

/**
* Provides a handle to the underlying scroll node.
Expand Down