feat: added Reanimated v2 support #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if it will drop the usage for reanimated1 or not? |
|
hi @sa8ab ! thanks for submitting this PR, i'll test it now |
gorhom
previously requested changes
Aug 18, 2020
There was a problem hiding this comment.
I wonder if it will drop the usage for reanimated1 or not?
yeah, this broke usage with Reanimated v1. However here are the solution:
in constants.ts, change the import of easing to be
const { Easing: EasingV1, EasingNode: EasingV2 } = require('react-native-reanimated')
const Easing = EasingV2 || EasingV1in BottomSheet.tsx
const { interpolate: interpolateV1, interpolateNode: interpolateV2 } = require('react-native-reanimated')
const interpolate = interpolateV2 || interpolateV1
|
hi @sa8ab , would you be able to update this pr ? i could pick it up :) |
gorhom
changed the base branch from
master
to
feature/reanimated-v2-compatibility
gorhom
added a commit
that referenced
this pull request
Aug 21, 2020
* feat: added Reanimated v2 support (#15) * Update Easing to work with reanimated 2 * compatible with reanimated 2 * chore: updated import Easing & interpolate from reanimated Co-authored-by: sa8ab <59901734+sa8ab@users.noreply.github.com>
|
Hey @gorhom sorry for my late delay, I'm glad it is in the new version. |
|
@sa8ab nah , no worries about it, thanks for the contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the library work with reanimated 2