refactor: add support for web without Babel/SWC #1741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactor: add support for web without Babel/SWC - refactor: add exhaustive deps rules to eslintrc for Reanimated hooks - fix: add missing metro-react-native-babel-preset (breaking linting)
|
thanks @joshsmith for submitting this PR <3 |
xilin
reviewed
Apr 11, 2024
| }, [ | ||
| _providedContainerHeight, | ||
| animatedContainerHeight.value, | ||
| animatedHandleHeight, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide enough information so that others can review your pull request:
The changes simply involved looking through each use of the necessary Reanimated hooks mentioned in #1740 and replacing them with optional dependency arrays or fixing the dependency arrays to use the new exhaustive deps rule recommended by Reanimated in their documentation. You simply need to review that these changes were inclusive.
Motivation
Closes #1740