Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Go version and Github Actions #44

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

coreydaley
Copy link
Contributor

@coreydaley coreydaley commented Aug 26, 2023

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Related Tickets & Documents

  • Related Issue #
  • Closes #

Added/updated tests?

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

Run verifications and test

  • make verify is passing
  • make test is passing

@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Merging #44 (763b108) into main (1cbd4c1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #44   +/-   ##
=======================================
  Coverage   71.25%   71.25%           
=======================================
  Files           1        1           
  Lines          80       80           
=======================================
  Hits           57       57           
  Misses         23       23           
Files Changed Coverage Δ
context.go 71.25% <ø> (ø)

@coreydaley coreydaley enabled auto-merge (squash) August 26, 2023 18:30
@coreydaley
Copy link
Contributor Author

@apoorvajagtap I have rearranged the Github Actions tests and also removed the Go version and OS matrices. What do you think?

@apoorvajagtap
Copy link
Member

@coreydaley the segregation helps with better context among the GHA.
Just curious about the removal of the OS matrix. We don't see any need to have the checks to be running on OSs other than ubuntu?

@coreydaley coreydaley merged commit a45ea70 into main Sep 22, 2023
7 checks passed
@coreydaley coreydaley deleted the coreydaley-patch-3 branch September 22, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants