Ensure jsonfile is flushed before running post-run-command #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
force-pushed
the
fix-jsonfile-close-order
branch
from
b8113de
to
48cb825
Compare
The test seems to pass without these extra Flush, but from what I can tell there's no guarantee the file is sycned to disk without these new calls.
dnephin
force-pushed
the
fix-jsonfile-close-order
branch
from
48cb825
to
db13c76
Compare
|
Oh, this was working because https://stackoverflow.com/a/64093650/444646. At least on POSIX systems the sync isn't necessary. Maybe this is necessary for windows? Either way I guess it doesn't hurt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While discussing the proposal in #303 I noticed the jsonfile is closed after running the
post-run-command. In some cases, I think it's possible the post-run-command would read the file before all the contents of the file are flushed.The test added in this commit seems to pass without these extra Flush, but from what I can tell there's no guarantee the file is sycned to disk without these new calls. Maybe that test would flake occasionally without these new calls to
Sync?