Don't treat debug messages as errors #336
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teaching
gotestsum
to recognize Golang cache debug output. Whengocachehash=1
orgocachetest=1
debug options are enabled, output is sent tostderr
.gotestum
treats unrecognisedstderr
messages as errors what makes test suite run marked as failed.Example of testing
gotestsum
repository without this PR. Each debug info line is treated as error:$ GODEBUG=gocachehash=1,gocachetest=1 ./gotestsum ... DONE 183 tests, 2 skipped, 13819 errors in 0.726s
After fixing the issue:
$ GODEBUG=gocachehash=1,gocachetest=1 ./gotestsum ... DONE 183 tests, 2 skipped in 0.523s