perf: the config.Writer
should be used in preference in elog Build
#306
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defaultConfig()
has been readWriter
from envego/core/elog/config.go
Line 55 in ee9e1c3
so we should give preference to
config.Writer
ego/core/elog/container.go
Lines 58 to 60 in 435ef98
If we don't set env but do set config, the
Writer
here will be ignored