This repository has been archived by the owner on Aug 26, 2021. It is now read-only.
[ARCH] 01 - Sass lib -> src & Yarn workspaces #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azerella
added
enhancement
azerella
changed the title
alex-page
suggested changes
Jan 25, 2019
There was a problem hiding this comment.
Lots of stuff has not been tested and a big change like this it will a requirement. I would recommend looking into testing local folders as npm packages. Make sure that you can npm i @gov.au/accordion and copy paste the react and html documentation from the designsystem website. If you can not there is an issue.
My builds seem to hang and not finish. It might be worth investigating async performance or changing limits.
I also noticed a bunch of spacing changes, indentation issues and just general things that have not been explained. Might have to sit down with you and go through them all.
You made a good judgement call running yarn --verbose there are lots of errors there that should not be showing up.
alex-page
reviewed
Jan 25, 2019
azerella
changed the title
azerella
force-pushed
the
feature/hoist-node-modules-to-root
branch
3 times, most recently
from
4e0faa8
to
c40f070
Compare
This was referenced Feb 7, 2019
azerella
changed the title
azerella
force-pushed
the
feature/hoist-node-modules-to-root
branch
from
783f0aa
to
79bba66
Compare
added 4 commits
February 8, 2019 11:49
Setup yarn workspaces First attempt at modifying helper.js
added 16 commits
February 8, 2019 11:49
Reverted helper react.es5.js changes back Added gitignore for react/tests/dist Updated ES6 dependency imports to pancake root folder
azerella
force-pushed
the
feature/hoist-node-modules-to-root
branch
from
8565ee2
to
6d8c870
Compare
…onents into feature/hoist-node-modules-to-root
azerella
changed the title
sukhrajghuman
force-pushed
the
feature/hoist-node-modules-to-root
branch
from
51e4ca6
to
b7aff71
Compare
added 2 commits
February 13, 2019 15:25
…onents into feature/hoist-node-modules-to-root
azerella
pushed a commit
that referenced
this pull request
Feb 22, 2019
* First steps with yarn workspaces * Switched sass imports to read from src Setup yarn workspaces First attempt at modifying helper.js * Removed pancake folder * Upgraded babel and webpack * Updated circleci image and build process * Upgraded webpack ES6 for babel-loader Upgraded ES6 helper babel process * Commented out devDep checks, need to rewrite * Added node-module caching to circleci * Put restore_cache key in wrong order :'( * Removed pancake root key Gave module versions some love Updated circleci comments * Package formatting * Installed mocha/chai over jest, removed jest * Updated 50% of unit tests * Renamed packages -> components * Installed babel preset minify * added preset to .babelrc * updated README.md * Trailing process.exit for circleci * Updated autoprefixer tag to be inline with spec Trialing node direct script over yarn * Added mode flag to webpack config - creates warning in webpack 4 * Playing around with puppetter args and circle images * Removed debug flags, trying node image * Updated circleci image * Helper should read from src for file check and build to lib/ * Correct webpack config to reference babel-preset-minify as a plugin not preset * Removed all instances of babel-preset-minify * Various tweaks based on PR review * Added back missing spacing * Added back es5 name convention * Webpack formatting * Forgot es5 name convention * Dependency shuffling * Added back ES6 dep comment * Trailing why git thinks _deps is new * Updated webpack output location Reverted helper react.es5.js changes back Added gitignore for react/tests/dist Updated ES6 dependency imports to pancake root folder * Added nuke script for pancake/ * Temporary resolved yarn workspace building by pretending animate requires sass * Added missing sass: name false key to animate * Reverted pretending animate hass sass * Resolved root and core vulnerabilities * Added missing whitespace in core * Updated engines, removed verbose --pancake from animate * Added back webpack ./bundle.js -> bundle.js * Updated local install instructions for yarn and grammar * Updated FAQ notes for yarn * Updated auds.json from latest develop * Upgraded circle node images to latest lts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #602
CHANGES
packages->components.cfignore- not used anymoresrc/overlib/node_modulesinto shared root foldernode_modules/mochaoverjestfor animate unit testswebpack 3->webpack 4- This includes moving to@babel/7which brings some really good optimizationsISSUES
sass-verioningfunctionality with this change. Reading our sass files fromsrc/results in versioning to fail as we are now checking files that haven't had their dependencies set. We should look at bringing this or an alternative of this back sometime in the future.NOTES
This branch fails to build in Windows due to pathing complications from
pancake. We should look at resolving this but our Windows support in general is something else to discuss.This PR will require publishing new changes to the following packages:
due to the minor changes of updating prefixer causing
text-decoration-skip: ink;->text-decoration-skip-ink: auto;