Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: DCMAW-10696 Fix the pipeline on the UI repo #146

Merged
merged 9 commits into from
Dec 17, 2024
Merged

Conversation

ThomasIent
Copy link
Contributor

@ThomasIent ThomasIent commented Dec 11, 2024

DCMAW-10696: Fix the pipeline on the UI repo

  • Swaps the remaining configuration to use mobile-android-pipelines
  • Fixes publishing by removing JavaDoc tasks taken from here

Commits

*This was actually an attempt at a fix as it was compose's @PreviewParameter that was throwing the exception

Evidence of the change

  • None

Checklist

Before creating the pull request

  • Commit messages that conform to conventional commit messages.
  • Ran the app locally ensuring it builds.
  • Tests pass locally.
  • Pull request has a clear title with a short description about the feature or update.
  • Created a draft pull request if it's not ready for review.

Before the CODEOWNERS review the pull request

  • Complete all Acceptance Criteria within Jira ticket.
  • Self-review code.
  • Successfully run changes on a testing device.
  • Complete automated Testing:
    • Unit Tests.
    • Integration Tests.
    • Instrumentation / Emulator Tests.
  • Review Accessibility considerations.
  • Handle PR comments.

Before merging the pull request

@ThomasIent ThomasIent marked this pull request as ready for review December 13, 2024 12:18
@ThomasIent ThomasIent requested review from a team as code owners December 13, 2024 12:18
Resolves: 10696
Update libs.versions.toml to add bundles section
Include a compose bundle
Add preview tooling to the compose dependencies
Update build.gradle.kts files to use compose bundle reference
Fix compose-tooling to debugImplementation
Fix compose-test-manifest to debugImplementation

Resolves: 10696
Transfer remaining configuration to mobile-android-pipelines
Some configuration was missed in the addition of mobile-android-pipelines

Resolves: 10696
Resolves: 10696
Resolves: 10696
Update build.gradle.kts to disable JavaDoc generation tasks for pages
These run due to some issue with an old dokka version being included with AGP and cause ASM9 issues
No JavaDoc stuff should run as we use Kotlin and KDoc through dokka

Resolves: 10696
Previously used the vale directory in config when the vale.ini file was expecting styles to be used
Swap to using styles

Resolves: 10696
Resolves: 10696
@ThomasIent ThomasIent merged commit e348da3 into main Dec 17, 2024
3 checks passed
@ThomasIent ThomasIent deleted the fix/DCMAW-10696 branch December 17, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants