-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: DCMAW-10696 Fix the pipeline on the UI repo #146
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasIent
force-pushed
the
fix/DCMAW-10696
branch
from
December 17, 2024 15:29
cd9b504
to
bc56063
Compare
alex-bradbury-gds
approved these changes
Dec 17, 2024
Resolves: 10696
Resolves: 10696
Update libs.versions.toml to add bundles section Include a compose bundle Add preview tooling to the compose dependencies Update build.gradle.kts files to use compose bundle reference Fix compose-tooling to debugImplementation Fix compose-test-manifest to debugImplementation Resolves: 10696
Transfer remaining configuration to mobile-android-pipelines Some configuration was missed in the addition of mobile-android-pipelines Resolves: 10696
Resolves: 10696
Resolves: 10696
Update build.gradle.kts to disable JavaDoc generation tasks for pages These run due to some issue with an old dokka version being included with AGP and cause ASM9 issues No JavaDoc stuff should run as we use Kotlin and KDoc through dokka Resolves: 10696
Previously used the vale directory in config when the vale.ini file was expecting styles to be used Swap to using styles Resolves: 10696
Resolves: 10696
ThomasIent
force-pushed
the
fix/DCMAW-10696
branch
from
December 17, 2024 17:01
47b2041
to
e42e829
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DCMAW-10696: Fix the pipeline on the UI repo
Commits
*This was actually an attempt at a fix as it was compose's @PreviewParameter that was throwing the exception
Evidence of the change
Checklist
Before creating the pull request
draft
pull request if it's not ready for review.Before the CODEOWNERS review the pull request
Before merging the pull request