Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not store internal content on serverless.variables as it's scheduled to be removed #14

Closed

Conversation

medikoo
Copy link

@medikoo medikoo commented Sep 14, 2021

serverless.variables is scheduled to be removed with v3 of the Framework

`serverless.variables` is scheduled to be removed with v3 of the Framework
@medikoo medikoo force-pushed the 0914-remove-variables-reference branch from eb15f05 to 3e3609c Compare November 30, 2021 14:58
@medikoo
Copy link
Author

medikoo commented Nov 30, 2021

@gozup Is there a chance you can look into this PR? Without this, the plugin will not work with upcoming Serverless Framework v3 release

@gozup
Copy link
Owner

gozup commented Dec 17, 2021

Hi @medikoo ,

Do you have any documented resource about it to share before I merge please?

Gozup

@medikoo
Copy link
Author

medikoo commented Dec 17, 2021

@gozup https://www.serverless.com/framework/docs/deprecations#NEW_VARIABLES_RESOLVER

The serlverless.variables is an instance of old variables resolver that will no longer be in effect in v3 (note I'm the author of this change)

@gozup
Copy link
Owner

gozup commented Dec 17, 2021

Hey @medikoo ,

I didn't merge your PR, but I've the modifications by myself since you edited the dist instead of the src. However, you're tagged as a contributor in the release: https://github.com/gozup/serverless-ssm-fetch/releases/tag/v1.1.2

Cheers!

@gozup gozup closed this Dec 17, 2021
@medikoo
Copy link
Author

medikoo commented Dec 17, 2021

Thank you @gozup !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants