Fix "unused function" warning seen with gcc. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! Can you please amend your commit with the same change for |
highestBitSet does not use log2 when using a newish Microsoft compiler or gcc. Therefore log2 needs to be defined only when neither using a newish Microsoft compiler, nor gcc. De Morgan's laws in action!
|
Done! |
gpakosz
added a commit
that referenced
this pull request
Dec 30, 2015
fixed unused function '__PackedArray_log2' warning seen with gcc.
|
Thanks Philip! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
highestBitSetdoes not uselog2when using a newish Microsoft compiler or gcc. Thereforelog2needs to be defined only when neither using a newish Microsoft compiler, nor gcc. De Morgan's laws in action!