Xcode 10 and Swift 4.2 fix #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Coupz You could also add |
|
Made the changes that @dstranz wrote above. |
|
Nice. Now we need to wait for @gpbl to accept this PR. |
Convert Example project to Swift 4.2
|
Yes it is alive again :) Sorry folks for the delays and thanks for the PR. |
|
@gpbl could we get a new release pushed out so that folks using pods can update? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
renamed kCALineJoinBevel to CAShapeLayerLineJoin.bevel so that SwiftChart is able to compile inside Xcode 10 and project set to Swift 4.2
This is my first PR on an open source project so if there is something false, please let me know 🙌