Grails 4.0.x #4
Merged
Grails 4.0.x #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having an issue with the registration Doesn't seem to be working like my other plugin...
The tests could be improved...
Grails 3.3 from virtualdogbert
---- Added CascadeConstraintRegistration used to register the constraint.
…ed maven-publish instead. Version now 4.0.0-SNAPSHOT
|
@rmorrise I decided to make my pull-request towards the GPC version (assuming that this is where it will live moving forward). Could you please review. Meanwhile I will try to get the release process up and running with GitHub Actions |
rmorrise
reviewed
Dec 1, 2021
rmorrise
reviewed
Dec 1, 2021
src/main/groovy/com/cscinfo/platform/constraint/CascadeConstraintRegistration.groovy
Outdated
Show resolved
Hide resolved
rmorrise
reviewed
Dec 1, 2021
src/main/groovy/com/cscinfo/platform/constraint/CascadeConstraint.groovy
Outdated
Show resolved
Hide resolved
rmorrise
reviewed
Dec 1, 2021
src/main/groovy/grails/cascade/validation/CascadeValidationGrailsPlugin.groovy
Outdated
Show resolved
Hide resolved
rmorrise
previously approved these changes
Dec 1, 2021
|
Thanks for updating this! |
* The official repository is now https://github.com/gpc/grails-cascade-validation * CascadeConstraint validates parameters as expected, includes added test * Various minor changes to plugin descriptor. * Improved README.md * Upgrade to Grails 4.0.13
|
@rmorrise Looks good now? |
Perfect! Thank you! |
rmorrise
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded version, verified in local build.