Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux create_package.sh script #93

Closed
wants to merge 7 commits into from

Conversation

ironictoo
Copy link

I converted the create_package script to bash, and added a few things needed for a linux package (create a .deb package, grab the appropriate linux libraries, etc).

It works on my system (Ubuntu 20.04.2 LTS) but I haven't done testing on other systems. I am willing to help with linux specific updates to cmake as well if you are interested (I had to make edits to get it to build on my system).

@jkfindeisen
Copy link
Collaborator

Sure, you could insert the linux specific updates to cmake in your linux_build branch, or have you already?

@ironictoo
Copy link
Author

I'll add the cmake edits to the branch on Monday

@ironictoo
Copy link
Author

I've updated my branch with all the linux specific edits I have. The main thing is CUBLAS linking from the main CMakeFile, but I also added two convenience scripts. One just runs the pip command to install the python wheel file, and the other runs all the boosts tests to make sure everything is working after build.

@jkfindeisen
Copy link
Collaborator

Thanks. I'll test it here.

@jkfindeisen
Copy link
Collaborator

In a few days there will be a new release. The Linux package script won't be part of it, but afterwards I'll look a bit more at it. If you want to run "all the boosts tests to make sure everything is working after build." just do "make test". It runs the tests automatically. I have again a Linux computer with all needed libraries here now, so I can test this PR.

@jkfindeisen jkfindeisen self-assigned this Aug 31, 2021
@jkfindeisen jkfindeisen self-requested a review August 31, 2021 10:49
@ironictoo
Copy link
Author

These changes were included in #94 so I'm going to close this.

@ironictoo ironictoo closed this Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants