Remove usage of the Theora codec #3358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm, I agree the webm bt601 version covers this case. |
kainino0x
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
LGTM! We copied these cases originally from WebGL. You'll want to remove the Theora WebGL tests too, see:
https://github.com/KhronosGroup/WebGL/tree/main/sdk/tests/resources
(and whatever tests reference them)
Yes, this is planned as well, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WebGPU CTS references exactly one Theora file, and after years of service, this codec is being retired from the Web.
Some context, for the two implementations that have historically supported Theora, Chromium (except on Android) and Gecko (all platforms):
If need be, I can provide a media file that has exactly the same characteristics and switch it here with a different codec. However, my understanding is that what we care about here are primaries / transfer function / color space / color range and then pixel format / plane arrangement, and this seems to be covered by other codecs, so we should not lose any coverage here, as far as WebGPU is concerned.