Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to web_socket_channel 3.0.0 #462

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Upgrade to web_socket_channel 3.0.0 #462

wants to merge 9 commits into from

Conversation

catapop84
Copy link
Contributor

This PR will upgrade to web_socket_channel 3.0.0

@knaeckeKami
Copy link
Collaborator

Thanks! It seems like there have been some changes in behavior, since a few tests fail

@catapop84
Copy link
Contributor Author

catapop84 commented Jun 5, 2024 •
edited
Loading

Hello @knaeckeKami, I saw. Trying to fix it. :)

@catapop84
Copy link
Contributor Author

@knaeckeKami , On my local pc test is valid. I'm using Dart SDK version: 3.4.1 (stable). That error might be from sdk. Can you check?

@knaeckeKami
Copy link
Collaborator

It fails on the format check.
Please try executing dart format with

Dart SDK version: 3.4.0 (stable)

@catapop84
Copy link
Contributor Author

catapop84 commented Jun 8, 2024 •
edited
Loading

@knaeckeKami I did format. it fails on auto reconnect. not sure why because on my local comp. is working. It's probably an OS problem. I'll test it on linux when I get home to further investigate the problem.

❌ test/gql_websocket_link_test.dart: WebSocketLink transport ws sub-protocol Auto reconnect (failed)
❌ test/gql_websocket_link_test.dart: WebSocketLink transport ws sub-protocol Auto reconnect (failed after test completion)

@knaeckeKami
Copy link
Collaborator

FWIW it also fails locally for me, in MacOS

@knaeckeKami
Copy link
Collaborator

possibly related: dart-lang/web_socket_channel#370

@agufagit agufagit mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@catapop84 @knaeckeKami