Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependencies handling #16

Merged
merged 5 commits into from
Oct 17, 2022
Merged

Fix dependencies handling #16

merged 5 commits into from
Oct 17, 2022

Conversation

tenntenn
Copy link
Member

  • Error handling
  • Catch result of dependencies

@tenntenn tenntenn changed the base branch from main to release-v0.3.3 October 14, 2022 09:49
@tenntenn tenntenn changed the base branch from release-v0.3.3 to main October 16, 2022 23:57
@tenntenn
Copy link
Member Author

I'd like to adapt tagpr instead of release branch. I created a PR (#17) which add a tagpr workflow of GitHub Actions. Then I changed the base branch of this PR to main.

sonatard
sonatard reviewed Oct 17, 2022
View reviewed changes
version.txt Outdated
v.0.3.2
v0.3.3
Copy link
Member

@sonatard sonatard Oct 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, forgot to update version.txt, next v0.3.4 please!
https://github.com/gqlgo/gqlanalysis/releases

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

sonatard
sonatard approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@sonatard sonatard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

@tenntenn tenntenn merged commit ca76431 into main Oct 17, 2022
@tenntenn tenntenn deleted the fix-deps branch October 17, 2022 05:53
@github-actions github-actions bot mentioned this pull request Oct 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonatard sonatard sonatard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tenntenn @sonatard