Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves error handling for release script #451

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Karm
Copy link
Collaborator

@Karm Karm commented Sep 23, 2024

Deals with some errors I used to tackle manually, e.g. missing JDK version and what it means, missing tag etc.

@Karm Karm requested a review from jerboaa September 23, 2024 18:05
@Karm Karm self-assigned this Sep 23, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 23, 2024
/*
* There used to be more JDK versions per 1 Mandrel release, e.g. Mandrel 21.3 could work with both
* Java 11 and 17. We aim at aligning releases with Java releases now, and we could simplify this code as
* soon as we completely get rid of all Mandrel 22.3.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Karm isn't 22.3 already out of support? If I am not mistaken we currently only support 23.0 (JDK 17) till November, 23.1 (JDK 21), and 24.1 (JDK 23).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zakkak It is out of support. Do you think the idea of 1 Mandrel 2 JDKs is dead then? Meaning, can I go and purge all that logic from the script?

There is a lot of data structures and logic wired to support that we are publishing more JDK builds for that particular Mandrel release.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think the idea of 1 Mandrel 2 JDKs is dead then?

It seems so. In theory there is nothing preventing us from doing it, but there doesn't seem to be any demand for it. Let's discuss it more broadly before doing it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants