Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add pre-release testing for Quarkus with fixed JDK version and locally installed maven artifact for graal-sdk #526

Closed
jerboaa opened this issue Jul 7, 2023 · 3 comments · Fixed by #565
Assignees
Labels
bug Something isn't working not-Stale

Comments

@jerboaa
Copy link
Collaborator

jerboaa commented Jul 7, 2023

Description

In order to avoid oracle#6831 in the future we should change our CI or add new testing which compiles Quarkus with a fixed (older JDK). This testing shall use a locally installed maven artifact from the mandrel build org.graalvm.sdk:graal-sdk as built like so:

$ cd sdk
$ mx build
$ mx --suite sdk maven-deploy --suppress-javadoc

Such a CI workflow shall parameterize on the JDK version to use for quarkus (e.g. JDK 11 for Quarkus 3.2) as it's expected to change from one release cycle to the next.

@jerboaa jerboaa added the bug Something isn't working label Jul 7, 2023
@jerboaa jerboaa added this to the 23.1.0.0-Final milestone Jul 7, 2023
@jerboaa jerboaa self-assigned this Jul 20, 2023
@jerboaa
Copy link
Collaborator Author

jerboaa commented Jul 21, 2023

graalvm/mandrel-packaging#354 adds support to the mandrel build to deploy to the local maven repository. After that has shipped the CI workflow should be like so:

1. Build mandrel with option '--maven-deploy-local' and recursively erasing
   '~/.m2/repository/org/graalvm/' before.
3. After step 1 the maven repo would only contain the locally built org.graalvm.* artefacts.
   The maven version for those would be in file `$GRAALVM_HOME/.maven-version`
5. Get JDK 11
6. Point at the JDK 11 install with JAVA_HOME and build quarkus, passing -Dgraal-sdk.version=$(cat $GRAALVM_HOME/.maven-version)

The idea would be that such a workflow would fail prior oracle#6949 and pass after it.

@github-actions
Copy link

This issue appears to be stale because it has been open 30 days with no activity. This issue will be closed in 7 days unless Stale label is removed, a new comment is made, or not-Stale label is added.

@jerboaa
Copy link
Collaborator Author

jerboaa commented Sep 11, 2023

Successful merge of #565 should complete this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working not-Stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant