-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for local maven deployment #355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good to me but I wonder if it's really necessary.
Can't you achieve local deployment with --maven-repo-id local --maven-version 3.6.0 --maven-url file://$HOME/.m2/repository
Thanks for the review! Don't merge this just yet (still some things coming).
It's a |
ed8e39c
to
4323ee1
Compare
@zakkak Please review again. graalvm/mandrel#526 (comment) contains a draft as to where this is going. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still LGTM, just added two minor comments.
This PR appears to be stale because it has been open 30 days with no activity. This PR will be closed in 7 days unless |
4323ee1
to
ea4d51c
Compare
"sdk:NATIVEIMAGE," + | ||
"sdk:COLLECTIONS," + | ||
"sdk:POLYGLOT," + | ||
"sdk:WORD," + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These four sub-modules need to be added to the deploy artifacts list, since otherwise only GRAAL_SDK
gets deployed to the local maven repo and its dependencies won't get resolved properly (as they're not in the local repo). This is in-line with the graal-sdk
artefact split.
This PR depends on #360 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @jerboaa
04296b8
to
ccd8489
Compare
ccd8489
to
b12cc4f
Compare
CI passes with this in the 23.1 branch. See https://github.com/jerboaa/mandrel-packaging/actions/runs/6099726559 I'm merging this. |
Example usage which installs the current version into the local maven repo (
~/.m2
on Linux):Closes: #354