Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mandrel 24.2.0 throws WARNING: Unknown module: org.graalvm.truffle specified to --enable-native-access #805

Closed
zakkak opened this issue Oct 24, 2024 · 6 comments
Assignees
Labels
affects/JDK24 Affects JDK 24 based Mandrel affects/24.2 Mandrel for JDK 24 bug Something isn't working

Comments

@zakkak
Copy link
Collaborator

zakkak commented Oct 24, 2024

Description

Since oracle#9892 mandrel issues the following warning:

WARNING: Unknown module: org.graalvm.truffle specified to --enable-native-access

How To Reproduce

path/to/mandrel-java24-24.2.0-deve05805b1084/bin/native-image HelloWorld

Configuration:

  • OS: Fedora 40
  • Architecture: AMD64
  • Mandrel version: 24.2.0-deve05805b1084
  • JDK version: 24+20-ea

Expected behavior

No warning should be shown.

Additional context

Since we don't ship truffle we need to remove it from the --enable-native-access in mandrel builds.

@jerboaa
Copy link
Collaborator

jerboaa commented Oct 24, 2024

@zakkak Does the same occur with community builds with --no-jlinking? If so I suggest raising it upstream.

@jerboaa jerboaa added affects/JDK24 Affects JDK 24 based Mandrel affects/24.2 Mandrel for JDK 24 labels Oct 24, 2024
@jerboaa jerboaa added this to the 24.2.0.0-Final milestone Oct 24, 2024
@zakkak
Copy link
Collaborator Author

zakkak commented Oct 24, 2024

@zakkak Does the same occur with community builds with --no-jlinking? If so I suggest raising it upstream.

I think that's not related to jlinking, but related to whether the build includes the truffle api package or not. I have an upstream fix ready, which I am currently testing :)

@jerboaa
Copy link
Collaborator

jerboaa commented Oct 24, 2024

OK

zakkak added a commit to zakkak/mandrel that referenced this issue Oct 24, 2024
zakkak added a commit to zakkak/mandrel that referenced this issue Oct 24, 2024
Since oracle#9892 got merged, passing the
parameter `--enable-native-access=org.graalvm.truffle` to GraalVM builds
not shipping the truffle api results in the following warning:

```
WARNING: Unknown module: org.graalvm.truffle specified to --enable-native-access
```

This patch checks whether the Truffle Runtime SVM component is part of
the GraalVM distribution to figure out whether the parameter should be
included or not.

Fixes graalvm#805
zakkak added a commit to zakkak/mandrel-packaging that referenced this issue Oct 24, 2024
Since we explicitly don't build and ship core truffle packages there is
no point in including this component.

Required by oracle/graal#9957 to resolve
graalvm/mandrel#805 but makes sense to merge
regardless of whether graalvm/mandrel#805 will
end up being accepted or not.
@jerboaa
Copy link
Collaborator

jerboaa commented Oct 24, 2024

Re-opening as the warning is still there.

@jerboaa jerboaa reopened this Oct 24, 2024
@jerboaa
Copy link
Collaborator

jerboaa commented Oct 25, 2024

Upstream PR which should fix this is now oracle#9964

@jerboaa
Copy link
Collaborator

jerboaa commented Oct 29, 2024

Closing this since oracle#9964 has now been integrated.

@jerboaa jerboaa closed this as completed Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects/JDK24 Affects JDK 24 based Mandrel affects/24.2 Mandrel for JDK 24 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants