Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework passing of arguments between the driver and the native-image generator runner #183

Merged
merged 2 commits into from
Dec 8, 2020

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Nov 27, 2020

Backports:

Fixes ResourcesITCase from Quarkus Main test suite.

Relates to: #169 and quarkusio/quarkus#13472

@zakkak zakkak added bug Something isn't working backport affects/20.3 labels Nov 27, 2020
@zakkak zakkak added this to the 20.3.0.0.Final milestone Nov 27, 2020
@zakkak zakkak self-assigned this Nov 27, 2020
@zakkak zakkak requested a review from Karm November 27, 2020 15:47
@zakkak
Copy link
Collaborator Author

zakkak commented Nov 27, 2020

\cc @ppalaga

@ppalaga
Copy link

ppalaga commented Nov 28, 2020

This helps, but see also oracle#3033

@zakkak
Copy link
Collaborator Author

zakkak commented Dec 1, 2020

@ppalaga I added b155924 to the PR which fixes oracle#3033

This should be enough to make Quarkus 1.11 work with Mandrel 20.3 even without quarkusio/quarkus#13473 (although we still need the latter for compatibility with GraalVM CE 20.3)

@zakkak
Copy link
Collaborator Author

zakkak commented Dec 3, 2020

Note: now that quarkusio/quarkus#13473 is merged, this PR is kind of "low-priority" ( I would still like to get it in though :) )

@ppalaga
Copy link

ppalaga commented Dec 3, 2020

b66c6c9 is important because the issue can occur also with other -H:* params (not only -H:IncludeResources that quarkusio/quarkus#13473 is working around).

Copy link
Collaborator

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with me.

@zakkak zakkak merged commit 9b1a0ff into graalvm:mandrel/20.3 Dec 8, 2020
@zakkak zakkak deleted the mandrel/20.3-fix-resources branch December 8, 2020 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants