Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around the absence of SpeculationReasonEncoding in OpenJDK11 #184

Merged
merged 3 commits into from
Dec 10, 2020
Merged

Work around the absence of SpeculationReasonEncoding in OpenJDK11 #184

merged 3 commits into from
Dec 10, 2020

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Dec 8, 2020

zakkak and others added 3 commits December 8, 2020 12:57
@zakkak
Work around the absence of SpeculationReasonEncoding in OpenJDK11
b870087 
Conflict resolution essentially bings this down to just making the
tests for the workaround non jdk11 specific.
@zakkak
Use jdk.vm.ci.meta.EncodedSpeculationReason with jdk8
08b59b4
@peter-hofer @zakkak
Style fixes.
a5417ca
@zakkak zakkak added bug Something isn't working backport affects/20.3 labels Dec 8, 2020
@zakkak zakkak added this to the 20.3.0.0.Final milestone Dec 8, 2020
@zakkak zakkak self-assigned this Dec 8, 2020
@zakkak zakkak requested review from jerboaa and Karm December 8, 2020 12:57
jerboaa
jerboaa approved these changes Dec 9, 2020
View reviewed changes
Copy link
Collaborator

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK.

Karm
Karm approved these changes Dec 9, 2020
View reviewed changes
Copy link
Collaborator

@Karm Karm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit as far as I understand the cause...

@zakkak zakkak merged commit 39ad511 into graalvm:mandrel/20.3 Dec 10, 2020
@zakkak zakkak deleted the mandrel/20.3-no-speculationreasonencoding-upstream branch December 10, 2020 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karm Karm Karm approved these changes

@jerboaa jerboaa jerboaa approved these changes

Assignees

@zakkak zakkak

Labels
affects/20.3 backport bug Something isn't working oca-signed
Projects
None yet
Milestone
20.3.0.0.Final
Development

Successfully merging this pull request may close these issues.
5 participants
@zakkak @jerboaa @Karm @graalvmbot @peter-hofer