Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the search path for agent collected config in the agent mode #47

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Fix the search path for agent collected config in the agent mode #47

merged 1 commit into from
Jun 15, 2021

Conversation

gradinac
Copy link
Contributor

Closes #44

@gradinac gradinac force-pushed the gradinac/gradle-agent-mode-fix branch from 4d10362 to 3247f10 Compare June 15, 2021 15:16
@gradinac gradinac force-pushed the gradinac/gradle-agent-mode-fix branch from 3247f10 to 34f560a Compare June 15, 2021 15:23
sbrannen
sbrannen reviewed Jun 15, 2021
View reviewed changes
Copy link
Collaborator

@sbrannen sbrannen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a glance, the changes look good, but I'd really like to see this covered in an automated test.

I'll create a separate issue to address that topic (see #48).

@gradinac
Copy link
Contributor Author

Thank you for the review! :) I'll move forward with merging this PR - I agree with you, this case should be covered by a test later on

@gradinac gradinac merged commit acf1474 into master Jun 15, 2021
@gradinac gradinac deleted the gradinac/gradle-agent-mode-fix branch June 16, 2021 08:48
@sbrannen sbrannen added the bug Something isn't working label Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrannen sbrannen sbrannen left review comments

Assignees
No one assigned
Labels
bug Something isn't working oracle-emp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gradle support for agent does not work.
3 participants
@gradinac @sbrannen @graalvmbot